Review: Resubmit
Thanks a lot for testing! Sorry, somehow missed this yesterday.
- Thanks for fixing the find-broadcast code, it compiles and works on my
system, too.
- Trunk is merged, luckily without conflicts.
- I went through the boost history, seems like version 1.48 is good enough. A
lot o
Continuous integration builds have changed state:
Travis build 2246. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/236078100.
Appveyor build 2081. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_ai_trainin
I ran a LAN game with Windows host and Linux client, no problem.
Will do more testing when the issues raised by Klaus have been addressed.
--
https://code.launchpad.net/~widelands-dev/widelands/net-boost-asio/+merge/324364
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/
Review: Needs Fixing compile, test
* I can connect to the metaserver, so networking basically works.
* With a second try I now died with:
Assertion failed: (state_ == OFFLINE), function login,
file
/Users/klaus/develop/widelands-repo/net-boost-asio/src/network/internet_gaming.cc,
line 118.
B
Trying an itenratgame now gives me:
InternetGaming: Client opened a game with the name BugHasi.
[NetHost]: Opening a listening IPv4 socket on TCP port 7396
[NetHost]: Opening a listening IPv6 socket on TCP port 7396
[LAN] Started an IPv6 socket on UDP port 7395
[LAN] Started an IPv4 socket on UDP
> I found Asio 1.10.6 / Boost 1.58 as part of the boost library
> provided by MacPorts (https://www.macports.org/)
>
> most recent is Asio 1.10.9 / Boost 1.64
>From CMakelists.txt:
find_package(Boost 1.48
COMPONENTS
unit_test_framework
regex
REQUIRED
system)
So, we require vers
OK you use some struct ifaddrs from
$FreeBSD: src/include/ifaddrs.h,v 1.3.32.1.4.1 2010/06/14 02:09:06 kensmith Exp
$
As OSX is bases on Freebsd no surprise here.
man getifaddr tells me
The ifaddrs structure contains at least the following entries:
struct ifaddrs *ifa_next;
OK checked some things,
I found Asio 1.10.6 / Boost 1.58 as part of the boost library
provided by MacPorts (https://www.macports.org/)
most recent is Asio 1.10.9 / Boost 1.64
I assume you are on Ubuntu, so I assume you are somehwere in the middle of
these versions.
Can anybody tell use the wi
tried to compile this an it failed me with:
net-boost-asio/src/network/network_lan_promotion.cc:90:26: error: no member
named
'ifa_ifu' in 'ifaddrs'
s = getnameinfo(ifa->ifa_ifu.ifu_broadaddr, sizeof(struct sockaddr_in),
So Do _you_ use some implementation detail, or do I have to chnan
The proposal to merge lp:~widelands-dev/widelands/fh1-multitexture into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fh1-multitexture/+merge/323903
--
Your team Widelands Developers is subscribed to
As long as both Travis and Appveyor continue to be green, bunnybot will not
post here again. SirVer stopped that, because it was too spammy.
Bunnybot will refuse to merge though if Travis and Appyeyor aren't both green.
Thanks for the testing and review! I know this was a complicated one.
@bunn
Review: Approve code review, compile, test
OK for me now, we should get this in and try to find those nasty crashes in
trunk.
I still do not get the whole story, though. Would like to see bunnybot again.
Will continue with that net-boost-asio next.
--
https://code.launchpad.net/~widelands-dev/w
Will we need a resubmit fro travis to kick in?
Looks I now have time to do a full review and some Debugging.
--
https://code.launchpad.net/~widelands-dev/widelands/fh1-multitexture/+merge/323903
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fh1-multitexture.
GunChleoc has proposed merging
lp:~widelands-dev/widelands/ai_trainingsites_proportion into lp:widelands.
Commit message:
Added new entry "trainingsites_max_percent" to AI building hints. If this is
not set, the percentages will be evenly distributed while loading the tribe.
TribeDescr now has
The proposal to merge lp:~widelands-dev/widelands/ai_trainingsites_proportion
into lp:widelands has been updated.
Commit Message changed to:
Added new entry "trainingsites_max_percent" to AI building hints. If this is
not set, the percentages will be evenly distributed while loading the tribe.
15 matches
Mail list logo
