Review: Resubmit

Thanks a lot for testing! Sorry, somehow missed this yesterday.
- Thanks for fixing the find-broadcast code, it compiles and works on my 
system, too.
- Trunk is merged, luckily without conflicts.
- I went through the boost history, seems like version 1.48 is good enough. A 
lot of fixes but no changes that should be relevant for us.
- Fixed the too early abort when only one broadcast failed. Does your system 
has an IPv6 (address)? Its strange that earlier the code detected IPv6 on your 
system but later on is unable to send using it.
- Whether to remove the broadcast for internet games is up to discussion. It 
was already in the code before I worked on it. Since it allows LAN clients to 
connect to our game I don't see any harm in it.
- Regarding the failed assertion: You connected to the metaserver, clicked 
"back" and connected again without restarting the game? Have there been any 
error messages before the assert? I am not sure whether this is fixed, when it 
happens again let me know.
-- 
https://code.launchpad.net/~widelands-dev/widelands/net-boost-asio/+merge/324364
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/net-boost-asio.

_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to     : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to