Regarding the "number has no integer representation" error: Since Lua 5.3 added
integer support, luaL_checkinteger does not seem to accept floating-point
numbers anymore. We need to make sure to pass integers from Lua where required.
These changes seem to do the trick:
=== modified file 'data/s
Besides the obvious error in Lua coroutine, there seems to be another issue
with the message that is supposed to show up, which ultimately leads to a
crash. This message (in CmdLuaCoroutine::execute) is constructed with icon and
title parameters swapped.
--
https://code.launchpad.net/~widelands
Tutorials and campaigns seem to be crashing:
Error in Lua Coroutine
[/home/miroslavr/Games/widelands/src/scripting/lua_errors.cc:22] [string
"scripting/ui.lua"]:102: bad argument #-1 to '__newindex' (number has no
integer representation)
Send message to all players and pause gameFatal exception:
The proposal to merge lp:~widelands-dev/widelands/python3 into lp:widelands has
been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/python3/+merge/291236
--
Your team Widelands Developers is subscribed to branch
lp:~widela
Review: Approve testing
Seems to work as intended.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1422347-no-scenario-replays/+merge/289582
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1422347-no-scenario-replays.
___
Review: Approve
I cannot imagine why Python3 should be slower, because it is a very simple
script and all test computing is done by the widelands binary. I am pretty sure
if you would do another run with Python 3 it should be equally fast (perhaps
your OS or your harddisk caches, or something
Seems to be working - I could even load some savegames, so I haven't upgraded
any packet numbers.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1543001-eris/+merge/291294
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1543
The proposal to merge lp:~widelands-dev/widelands/bug-1512151-load-small-map
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1512151-load-small-map/+merge/290802
--
Your team Widelands Develope
The proposal to merge lp:~widelands-dev/widelands/string-fixes into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/291335
--
Your team Widelands Developers is subscribed to branch
OK, I'll try the Lua 5.3 version then to see if it will run on my system :)
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1543001-eris/+merge/291294
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1543001-eris into lp:widela
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/291335
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/string-fixes.
___
Mailing list: https://launchpad.net/~widelands-dev
Po
Thanks!
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1512151-load-small-map/+merge/290802
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1512151-load-small-map.
___
Mailing list: ht
Review: Approve review / test / compile
$ ./regression_test.py -b ./widelands ; ## thats Python 3.4.4
Ran 32 tests in 1018.389s
$ python2.7 ./regression_test.py -b ./widelands
...
Ran 32 tests in 616.502s
Works but Python 3.4.4 was much slower.
Well I used this first so all files where cached
On OSX (with macports) I have 'lua @5.3.1_2 (lang)'. hope this helps
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1543001-eris/+merge/291294
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-1543001-eris into lp:widelands.
_
Continuous integration builds have changed state:
Travis build 984. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/121502471.
Appveyor build 817. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1543001_
SirVer is correct. Here's an explanation:
https://github.com/fnuecke/eris/tree/master-lua5.3#core-library
You don't need to have Lua installed on your system at all.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1543001-eris/+merge/291294
Your team Widelands Developers is requested t
Review: Approve
LGTM.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1512151-load-small-map/+merge/290802
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1512151-load-small-map.
___
Mailing list: http
Review: Approve
LGTM.
--
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/291335
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/string-fixes.
___
Mailing list: https://launchpad.net/~widelands
I think Eris is lua 5.3 - Eris bundles all of lua with it since it needs the
private headers for serialization. So by updating Eris, we switch to lua 5.3.
This is from my memory. I cannot check right now, but it should be documented
on the GitHub project page or the commit history of Eris.
>
Continuous integration builds have changed state:
Travis build 985. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/121622180.
Appveyor build 818. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_python3-818.
Review: Approve
It's working for me now :)
--
https://code.launchpad.net/~widelands-dev/widelands/python3/+merge/291236
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/python3.
___
Mailing list: https://launchpad.net
Continuous integration builds have changed state:
Travis build 974. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/121219787.
Appveyor build 807. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_string_fixes
GunChleoc has proposed merging lp:~widelands-dev/widelands/string-fixes into
lp:widelands.
Commit message:
Fixed editor tooltips and renamed "Noise height" to "Random height".
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1421942 in widelands: "Unified term for "
23 matches
Mail list logo
