Could you also please remove the NOCOM line from artifacts.lua?
--
https://code.launchpad.net/~widelands-dev/widelands/artifacts/+merge/276527
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/artifacts.
___
Mailing lis
Review: Approve
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1516777/+merge/277701
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1516777.
___
Mailing list: https://launchpad.net/~widelands-dev
Po
Review: Approve
--
https://code.launchpad.net/~widelands-dev/widelands/string-fixes/+merge/277693
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/string-fixes.
___
Mailing list: https://launchpad.net/~widelands-dev
Review: Approve
Just two nits on the c++ part:
- In editor_main_menu_save_map.cc: pull out a reference to eia().egbase() - it
is used like a dozen times.
- In void FullscreenMenuLaunchMPG::win_condition_update(): I suggest pulling
out a function for the 'else' block to make the code more reada
Yes, I would like that - you obviously know a lot more about the map loading
code than I do. Would you like to take this on?
--
https://code.launchpad.net/~widelands-dev/widelands/map_compatibility/+merge/276088
Your team Widelands Developers is requested to review the proposed merge of
lp:~wide
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1516777 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1516777 in widelands: "Atlantean corn farms unproductive"
https://bugs.launchpad.net/widelands/+bug/1516777
For more details,
GunChleoc has proposed merging lp:~widelands-dev/widelands/string-fixes into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1421942 in widelands: "Unified term for "Black" and "Wasteland""
https://bugs.launchpad.net/widelands/+bug/1421942
Bug #148
I have finished reviewing the Lua code and testing. Now somebody needs to
review the C++ changes - they are all in 1 commit:
https://bazaar.launchpad.net/~widelands-dev/widelands/artifacts/revision/7571
--
https://code.launchpad.net/~widelands-dev/widelands/artifacts/+merge/276527
Your team Wide
Review: Approve
--
https://code.launchpad.net/~widelands-dev/widelands/artifacts/+merge/276527
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/artifacts.
___
Mailing list: https://launchpad.net/~widelands-dev
Post t
The proposal to merge lp:~franku/widelands-website/little_navi_changes into
lp:widelands-website has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~franku/widelands-website/little_navi_changes/+merge/276625
--
Your team Widelands Developers i
Sorry for the delay. This is deployed now. Thanks!
--
https://code.launchpad.net/~franku/widelands-website/little_navi_changes/+merge/276625
Your team Widelands Developers is subscribed to branch lp:widelands-website.
___
Mailing list: https://launchpad
11 matches
Mail list logo
