Review: Approve

Just two nits on the c++ part:

- In editor_main_menu_save_map.cc: pull out a reference to eia().egbase() - it 
is used like a dozen times. 
- In void FullscreenMenuLaunchMPG::win_condition_update(): I suggest pulling 
out a function for the 'else' block to make the code more readable. Your call.


-- 
https://code.launchpad.net/~widelands-dev/widelands/artifacts/+merge/276527
Your team Widelands Developers is subscribed to branch 
lp:~widelands-dev/widelands/artifacts.

_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to     : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to