Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/find_attack_soldiers into lp:widelands

2015-04-22 Thread TiborB
" the list of soldiers in a militarysite is not updated until the windows of the militarysite is..." - this would be very useful, but personally I am not able to help with this :( -- https://code.launchpad.net/~widelands-dev/widelands/find_attack_soldiers/+merge/245276 Your team Widelands Develo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/find_attack_soldiers into lp:widelands

2015-04-22 Thread Martin Schmidt
I guess it is ready to merge. What is implemented: - defend with "strongest", attack with "strongest" - drop "weakest", but only unwounded soldiers (because wounded soldiers will heal) I am quite happy with how it works and feels playing with this branch. What is missing: - the list of soldier

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/empire into lp:widelands

2015-04-22 Thread TiborB
Review: Approve I think it can go -- https://code.launchpad.net/~widelands-dev/widelands/empire/+merge/257141 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/empire. ___ Mailing list: https://launchpad.net/~widelands

[Widelands-dev] [Merge] lp:~elisabeth/widelands/empire into lp:widelands

2015-04-22 Thread GunChleoc
The proposal to merge lp:~elisabeth/widelands/empire into lp:widelands has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~elisabeth/widelands/empire/+merge/254718 -- Your team Widelands Developers is requested to review the proposed

Re: [Widelands-dev] [Merge] lp:~elisabeth/widelands/empire into lp:widelands

2015-04-22 Thread GunChleoc
I guess so. https://code.launchpad.net/~widelands-dev/widelands/empire/+merge/257141 -- https://code.launchpad.net/~elisabeth/widelands/empire/+merge/254718 Your team Widelands Developers is requested to review the proposed merge of lp:~elisabeth/widelands/empire into lp:widelands.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/empire into lp:widelands

2015-04-22 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/empire into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1424950 in widelands: "strange character relationships in the empire campaigns" https://bugs.launchpad.net/widelands/+bug/1424950

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/find_attack_soldiers into lp:widelands

2015-04-22 Thread TiborB
I second SirVer's question: Is this branch ready for review/merging now or do you still want to work on it? It seems there is some work to do here yet. -- https://code.launchpad.net/~widelands-dev/widelands/find_attack_soldiers/+merge/245276 Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~elisabeth/widelands/empire into lp:widelands

2015-04-22 Thread TiborB
@GunChleoc - re new branch - so this one should be unproposed for merge and your new one proposed for merge, correct? -- https://code.launchpad.net/~elisabeth/widelands/empire/+merge/254718 Your team Widelands Developers is requested to review the proposed merge of lp:~elisabeth/widelands/empire

Re: [Widelands-dev] [Merge] lp:~hjd/widelands/tests-poc into lp:~widelands-dev/widelands/debian

2015-04-22 Thread TiborB
Seems useful. In regard to these never-ending tests - I guess that problem are tests with fake mouse movements -- https://code.launchpad.net/~hjd/widelands/tests-poc/+merge/250533 Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/tests-poc into lp:~wi

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1390793 into lp:widelands

2015-04-22 Thread TiborB
I see you spend quite a lot of time on this, I am not able to judge the code, but from user interface point of view - few comments and/or ideas. 1. Why is there the seafaring checkbox - should not be this be recognized from the map itself - if there are portspaces then the map is seafaring, righ