OK, I added some sleep commands to make sure I see these, but these methods
don't seem to be involved with printing anything into the tooltips. I guess
there is a generic action called someplace just to move to the next step with
the "when" keyword, and that this action also creates its negation
The Atlantean mill has "return=skipped when site has corn and economy needs
cornflour and not economy needs blackrootflour" (in produce_blackrootflour) and
sleep afterwards, without any other commands. I think that here, the string in
question will be displayed.
I am not sure, but this program c
I have not tested it in the game, but some ideas based on these comments:
- I imagined that when the news window is open, 1-5 would act on it (6-0 should
do nothing). When it is not open, they work as location marker. Ctrl+number is
also already used. I do not know if Widelands currently supports
if the hotkeys will be like Ctrl+1, then it will be obvious that they are
hotkeys and no confusion for user
--
https://code.launchpad.net/~widelands-dev/widelands/bug-987510/+merge/236231
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/bug-
I overlooked that we already have the hotkeys 1-9 in use. I willcome up with
different hotkeys.
> Or even better, but probably more work for you - remove that flag on the
> bottom and add new column that would contain a particular flag for the
> message.
This column would need a header and eat u
It only is called when the production program starts with "Skipped when". I
didn't figure out why. I'm also not sure that I could get these string o screen
at all, because it immediately switched to an alternative progrm without
sleeping first. If you wish me to investigate further, I can add so
maybe we just can agree that 'green' should be replaced by 'buildings allowed'
(or anything in this sense) in the tooltips and merge this branch.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1174075/+merge/235763
Your team Widelands Developers is subscribed to branch
lp:~widelands
I remember that I reverse engineered the types of terrain that settlers 2 would
use. I then picked keywords that seemed reasonable to me back then, they are
terrible of course from what we see today.
green only means that buildings and trees and stuff can grow there. Similar to
the others: they
Have we ever figured out why this method gets called in the first place? It
seems like you were confident in your original branch that it should never get
called.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1352943/+merge/236246
Your team Widelands Developers is requested to revie
Review: Approve
One nit.
Diff comments:
> === modified file 'src/logic/production_program.cc'
> --- src/logic/production_program.cc 2014-09-14 11:31:58 +
> +++ src/logic/production_program.cc 2014-09-27 15:57:22 +
> @@ -950,23 +950,24 @@
> group_list.push_back(w
Review: Approve
Seems like this are fairly small fixes. In general (i.e. if you make bigger
fixes), menus should use UI::Box for layouting as much as possible instead of
absolute positioning.
I skimmed this only, but I find the formatting in some places to be weird. I
think we should finally d
Review: Approve
+1 for cross team reviews! We really have to find a way forward that does not
make me the bottleneck all the time. I am stressed out a bit over Widelands
responsibilities anyways :).
Also, code reviews are very educational for the reviewer and the reviewee. And
they are great f
I just found that in world/terrains/init.lua terrain types are defined with "is
=" as green, including those that definitelly are not 'green'. Maybe the
keyword was improperly picked?
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1174075/+merge/235763
Your team Widelands Developers
Probably hotkey does not work on my (linux) at all - but no problem now
> The flag on the bottom is not the currently selected category, but the
> category of the current message.
Oh yes, I did not got it, now it makes sense
Also you can consider "Type of selected message" or "Type of highlight
Indeed, it does not crash anymore
I dont know the production_program.cc logic, but this does not look like a good
solution. It seems to me "unsystematic"... Of course, I can easily be wrong...
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1352943/+merge/236246
Your team Widelands De
Speaking of the hotkeys, how do they work together with the "area bookmarks" we
have currently? At the moment I can use Ctrl+number to store a location, then
later go back to it by pressing the number. How will we tell whether the user
wish to toggle filtering in the news window or go to another
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1352943 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1352943 in widelands: "production_program.cc:249 Not implemented."
https://bugs.launchpad.net/widelands/+bug/1352943
For more
Hotkeys work just fine with me, the toggle on/off. Is it '$number'.
1. That would make the filter harder to implement - I just went with the easy
option.
2. The flag on the bottom is not the currently selected category, but the
category of the current message. Maybe the tooltip should be cleare
18 matches
Mail list logo
