Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1293158 into lp:widelands

2014-06-05 Thread GunChleoc
Added some fixes + more comments. Diff comments: > === modified file 'src/editor/tools/editor_info_tool.cc' > --- src/editor/tools/editor_info_tool.cc 2014-03-09 10:28:39 + > +++ src/editor/tools/editor_info_tool.cc 2014-05-29 17:16:25 + > @@ -49,16 +49,11 @@ > Widelands::

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1324137 into lp:widelands

2014-06-05 Thread GunChleoc
Added some fixes. Some issues are still open. Diff comments: > === modified file 'doc/sphinx/source/tutorial.rst' > --- doc/sphinx/source/tutorial.rst2013-04-03 09:06:34 + > +++ doc/sphinx/source/tutorial.rst2014-05-29 10:48:20 + > @@ -269,4 +269,62 @@ > coroutines share the same

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1322473 into lp:widelands

2014-06-05 Thread GunChleoc
Fixed everything except for some open questions. Diff comments: > === modified file 'maps/MP Scenarios/Island > Hopping.wmf/scripting/multiplayer_init.lua' > --- maps/MP Scenarios/Island Hopping.wmf/scripting/multiplayer_init.lua > 2014-03-25 06:18:48 + > +++ maps/MP Scenarios/Island

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1074353 into lp:widelands

2014-06-05 Thread GunChleoc
I think in the code is better, because we would end up with a very big screen full of stuff. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1074353/+merge/221095 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1074353 into l

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1324137 into lp:widelands

2014-06-05 Thread GunChleoc
Somments to the suggestions Diff comments: > === modified file 'doc/sphinx/source/tutorial.rst' > --- doc/sphinx/source/tutorial.rst2013-04-03 09:06:34 + > +++ doc/sphinx/source/tutorial.rst2014-05-29 10:48:20 + > @@ -269,4 +269,62 @@ > coroutines share the same environment and c

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1293158 into lp:widelands

2014-06-05 Thread GunChleoc
Some comments to the nits. Diff comments: > === modified file 'src/editor/tools/editor_info_tool.cc' > --- src/editor/tools/editor_info_tool.cc 2014-03-09 10:28:39 + > +++ src/editor/tools/editor_info_tool.cc 2014-05-29 17:16:25 + > @@ -49,16 +49,11 @@ > Widelands::Field &

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1322473 into lp:widelands

2014-06-05 Thread GunChleoc
Some comments to the comments - I didn't notive this until now :( Diff comments: > === modified file 'maps/MP Scenarios/Island > Hopping.wmf/scripting/multiplayer_init.lua' > --- maps/MP Scenarios/Island Hopping.wmf/scripting/multiplayer_init.lua > 2014-03-25 06:18:48 + > +++ maps/MP