Title: [137599] trunk/Tools
Revision 137599
Author jpar...@chromium.org
Date 2012-12-13 09:08:45 -0800 (Thu, 13 Dec 2012)
Log Message
Loader_unittests should reset state between runs.
https://bugs.webkit.org/show_bug.cgi?id=104862
Reviewed by Dirk Pranke.
The loader_unittests were not r
Title: [137693] trunk/Tools
Revision 137693
Author jpar...@chromium.org
Date 2012-12-13 18:02:51 -0800 (Thu, 13 Dec 2012)
Log Message
Dashboard cleanup: remove usage of global g_builders.
https://bugs.webkit.org/show_bug.cgi?id=104941
Reviewed by Dirk Pranke.
The dashboards use a lot of
Title: [138733] trunk/Tools
Revision 138733
Author jpar...@chromium.org
Date 2013-01-03 13:30:32 -0800 (Thu, 03 Jan 2013)
Log Message
Add unit test for default builder for the dashboards.
https://bugs.webkit.org/show_bug.cgi?id=105972
Reviewed by Dirk Pranke.
* TestResultServer/static-d
Title: [138762] trunk/Tools
Revision 138762
Author jpar...@chromium.org
Date 2013-01-03 16:26:26 -0800 (Thu, 03 Jan 2013)
Log Message
Dashboard cleanup: remove usage of global g_defaultBuilderName
https://bugs.webkit.org/show_bug.cgi?id=106043
Use now public defaultBuilder() from the Bui
Title: [139082] trunk/Tools
Revision 139082
Author jpar...@chromium.org
Date 2013-01-08 11:00:33 -0800 (Tue, 08 Jan 2013)
Log Message
Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
https://bugs.webkit.org/show_bug.cgi?id=106254
Remove the global variable g_hasDoneInitialPageGen
Title: [139097] trunk/Tools
Revision 139097
Author jpar...@chromium.org
Date 2013-01-08 12:33:08 -0800 (Tue, 08 Jan 2013)
Log Message
Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
https://bugs.webkit.org/show_bug.cgi?id=106356
g_buildersThatFailedToLoad
Title: [139260] trunk/Tools
Revision 139260
Author jpar...@chromium.org
Date 2013-01-09 17:33:34 -0800 (Wed, 09 Jan 2013)
Log Message
Dashboard cleanup: remove dead code.
https://bugs.webkit.org/show_bug.cgi?id=106509
Reviewed by Dirk Pranke.
* TestResultServer/static-dashboards/dashboa
Title: [139270] trunk/Tools
Revision 139270
Author jpar...@chromium.org
Date 2013-01-09 18:35:36 -0800 (Wed, 09 Jan 2013)
Log Message
Dashboard Cleanup: Reload the page as soon as we know we need to.
https://bugs.webkit.org/show_bug.cgi?id=106515
No need to continue parsing all of the da
Title: [139272] trunk/Tools
Revision 139272
Author jpar...@chromium.org
Date 2013-01-09 18:50:22 -0800 (Wed, 09 Jan 2013)
Log Message
Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
https://bugs.webkit.org/show_bug.cgi?id=106514
This is old c
Title: [139348] trunk/Tools
Revision 139348
Author jpar...@chromium.org
Date 2013-01-10 11:52:33 -0800 (Thu, 10 Jan 2013)
Log Message
Dashboard Cleanup: Do not generate the page if we are about to reload.
https://bugs.webkit.org/show_bug.cgi?id=106584
Reviewed by Dirk Pranke.
Move the l
_loadNext();
},
+isLoadingComplete: function()
+{
+return this._loadingComplete;
+},
_loadNext: function()
{
var loadingStep = this._loadingSteps.shift();
if (!loadingStep) {
+this._loadingComplete = true;
+// FIXME(jparent): Loader should
Title: [139522] trunk/Tools
Revision 139522
Author jpar...@chromium.org
Date 2013-01-11 16:41:48 -0800 (Fri, 11 Jan 2013)
Log Message
Builder should not be a valid parameter for stats dashboard
https://bugs.webkit.org/show_bug.cgi?id=106698
Reviewed by Dirk Pranke.
Since builder is a da
Title: [140083] trunk/Tools
Revision 140083
Author jpar...@chromium.org
Date 2013-01-17 18:16:48 -0800 (Thu, 17 Jan 2013)
Log Message
Flakiness dashboard assumes there must be ToT tests
https://bugs.webkit.org/show_bug.cgi?id=107155
Remove group as a default parameter, since we can't act
Title: [140217] trunk/Tools
Revision 140217
Author jpar...@chromium.org
Date 2013-01-18 16:40:17 -0800 (Fri, 18 Jan 2013)
Log Message
Add back 'group' as a default cross dashboard parameter, but with null as its value.
https://bugs.webkit.org/show_bug.cgi?id=107336
We need to have 'group
Title: [141355] trunk/Tools
Revision 141355
Author jpar...@chromium.org
Date 2013-01-30 18:11:47 -0800 (Wed, 30 Jan 2013)
Log Message
Add a concept of dashboard parameters that invalidate others
https://bugs.webkit.org/show_bug.cgi?id=108362
Reviewed by Dirk Pranke.
There are certain pa
Title: [136348] trunk/Tools
Revision 136348
Author jpar...@chromium.org
Date 2012-12-02 10:49:57 -0800 (Sun, 02 Dec 2012)
Log Message
Remove dead code in flakiness dashboard for obsolete buildDir option
https://bugs.webkit.org/show_bug.cgi?id=103792
Reviewed by Dirk Pranke.
* TestResult
Title: [137383] trunk/Tools
Revision 137383
Author jpar...@chromium.org
Date 2012-12-11 16:36:00 -0800 (Tue, 11 Dec 2012)
Log Message
Dashboard unit tests should not make xhrs.
https://bugs.webkit.org/show_bug.cgi?id=104598
Reviewed by Dirk Pranke.
The unit test were requesting 25 files
Title: [141838] trunk/Tools
Revision 141838
Author jpar...@chromium.org
Date 2013-02-04 17:30:14 -0800 (Mon, 04 Feb 2013)
Log Message
Setting tests on flakiness dashboard should invalidate builder.
https://bugs.webkit.org/show_bug.cgi?id=108521
Reviewed by Dirk Pranke.
When you move int
Title: [141839] trunk/Tools
Revision 141839
Author jpar...@chromium.org
Date 2013-02-04 17:46:43 -0800 (Mon, 04 Feb 2013)
Log Message
Dashboard cleanup: Make builder a real dashboardSpecificParameter.
https://bugs.webkit.org/show_bug.cgi?id=108706
Reviewed by Dirk Pranke.
Add builder to
Title: [141941] trunk/Tools
Revision 141941
Author jpar...@chromium.org
Date 2013-02-05 15:37:35 -0800 (Tue, 05 Feb 2013)
Log Message
Add cc_unittests to the dashboards
https://bugs.webkit.org/show_bug.cgi?id=108878
Reviewed by Dirk Pranke.
* TestResultServer/static-dashboards/builders.
Title: [129563] trunk/Tools
Revision 129563
Author jpar...@chromium.org
Date 2012-09-25 15:37:02 -0700 (Tue, 25 Sep 2012)
Log Message
Make test_shell_tests show up in flakiness dashboard.
https://bugs.webkit.org/show_bug.cgi?id=97585
Reviewed by Dirk Pranke.
test_shell_tests run only on
Title: [144845] trunk/Tools
Revision 144845
Author jpar...@chromium.org
Date 2013-03-05 16:18:49 -0800 (Tue, 05 Mar 2013)
Log Message
Dashboard cleanup: move string utilities into their own namespace.
https://bugs.webkit.org/show_bug.cgi?id=111485
Reviewed by Ojan Vafai.
One of many pi
Title: [144968] trunk/Tools
Revision 144968
Author jpar...@chromium.org
Date 2013-03-06 13:00:54 -0800 (Wed, 06 Mar 2013)
Log Message
Dashboard cleanup: remove dashboard time logging.
https://bugs.webkit.org/show_bug.cgi?id=111608
Reviewed by Dirk Pranke.
Remove logTime. It was never a
Title: [145028] trunk/Tools
Revision 145028
Author jpar...@chromium.org
Date 2013-03-06 19:48:16 -0800 (Wed, 06 Mar 2013)
Log Message
Dashboard cleanup: Move all dashboard ui related code into ui.js.
https://bugs.webkit.org/show_bug.cgi?id=111621
Reviewed by Ojan Vafai.
Creates ui.js, a
Title: [145146] trunk/Tools
Revision 145146
Author jpar...@chromium.org
Date 2013-03-07 15:48:40 -0800 (Thu, 07 Mar 2013)
Log Message
showAllRuns checkbox no longer works on the stats dashboard
https://bugs.webkit.org/show_bug.cgi?id=111673
Reviewed by Ojan Vafai.
Stats dashboard does n
Title: [145294] trunk/Tools
Revision 145294
Author jpar...@chromium.org
Date 2013-03-08 17:31:15 -0800 (Fri, 08 Mar 2013)
Log Message
Cleanup: Remove dead code.
https://bugs.webkit.org/show_bug.cgi?id=111900
Reviewed by Dirk Pranke.
Treemap overrides a global function that used to be in
{
var loadingStep = this._loadingSteps.shift();
if (!loadingStep) {
this._loadingComplete = true;
+this._addErrors();
// FIXME(jparent): Loader should not know about global
// functions, should use a c
prototype = {
@@ -91,10 +91,7 @@
if (!loadingStep) {
this._loadingComplete = true;
this._addErrors();
-// FIXME(jparent): Loader should not know about global
-// functions, should use a callback or dispatch load
-// event instead.
-
Title: [145679] trunk/Tools
Revision 145679
Author jpar...@chromium.org
Date 2013-03-12 21:14:17 -0700 (Tue, 12 Mar 2013)
Log Message
Cleanup: Move flatten-trie to loader.
https://bugs.webkit.org/show_bug.cgi?id=112196
Reviewed by Dirk Pranke.
flatten-trie is used only by the loader, so
Title: [145783] trunk/Tools
Revision 145783
Author jpar...@chromium.org
Date 2013-03-13 20:33:47 -0700 (Wed, 13 Mar 2013)
Log Message
CLeanup: remove unnecessary call to parseParameters.
https://bugs.webkit.org/show_bug.cgi?id=112309
Reviewed by Ojan Vafai.
We call parseCrossDashboardPa
ourceLoader.isLoadingComplete())
-return;
-
if (parseParameters())
generatePage();
}
-window._onhashchange_ = handleLocationChange;
+// TODO(jparent): Move this to upcoming History object.
+function intializeHistory() {
+window._onhashchange_ = handleLocationChange;
+handleLoc
Title: [146106] trunk/Tools
Revision 146106
Author jpar...@chromium.org
Date 2013-03-18 12:56:13 -0700 (Mon, 18 Mar 2013)
Log Message
Cleanup: Move timeline_exporer js out of html file into js.
https://bugs.webkit.org/show_bug.cgi?id=112188
Reviewed by Dirk Pranke.
Moves the _javascript
Title: [146127] trunk/Tools
Revision 146127
Author jpar...@chromium.org
Date 2013-03-18 14:43:19 -0700 (Mon, 18 Mar 2013)
Log Message
Cleanup: Move js for treemap and aggregate_results into own js files.
https://bugs.webkit.org/show_bug.cgi?id=112618
Reviewed by Dirk Pranke.
No function
{
-equal(window.location.hash, '#useTestData=true');
-deepEqual(queryHashAsMap(), {useTestData: 'true'});
-});
-
</del><span class="cx"> test('parseCrossDashboardParameters', 2, function() {
</span><span class="cx"> equa
quot;group should have been invalidated");
+});
+
+test('shouldHideTest', 10, function() {
+var historyInstance = new history.History();
+historyInstance.parseParameters();
+// FIXME(jparent): Change to use the flakiness_dashboard's history object
+// once it exists, rather
dSpecificStateValues = {
rawValues: false
};
+
+var aggregateResultsConfig = {
+defaultStateValues: defaultDashboardSpecificStateValues,
+generatePage: generatePage,
+handleValidHashParameter: handleValidHashParameter,
+};
+
+// FIXME(jparent): Eventually remove all usage of global histor
36 matches
Mail list logo
