Title: [136348] trunk/Tools
- Revision
- 136348
- Author
- jpar...@chromium.org
- Date
- 2012-12-02 10:49:57 -0800 (Sun, 02 Dec 2012)
Log Message
Remove dead code in flakiness dashboard for obsolete buildDir option
https://bugs.webkit.org/show_bug.cgi?id=103792
Reviewed by Dirk Pranke.
* TestResultServer/static-dashboards/dashboard_base.js:
(initBuilders):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (136347 => 136348)
--- trunk/Tools/ChangeLog 2012-12-02 17:25:18 UTC (rev 136347)
+++ trunk/Tools/ChangeLog 2012-12-02 18:49:57 UTC (rev 136348)
@@ -1,3 +1,13 @@
+2012-12-02 Julie Parent <jpar...@chromium.org>
+
+ Remove dead code in flakiness dashboard for obsolete buildDir option
+ https://bugs.webkit.org/show_bug.cgi?id=103792
+
+ Reviewed by Dirk Pranke.
+
+ * TestResultServer/static-dashboards/dashboard_base.js:
+ (initBuilders):
+
2012-12-02 Dirk Pranke <dpra...@chromium.org>
nrwt: clean up logic for retrying failed tests a bit
Modified: trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js (136347 => 136348)
--- trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2012-12-02 17:25:18 UTC (rev 136347)
+++ trunk/Tools/TestResultServer/static-dashboards/dashboard_base.js 2012-12-02 18:49:57 UTC (rev 136348)
@@ -196,14 +196,6 @@
g_crossDashboardState[key] = value == 'true';
return true;
- case 'buildDir':
- if (value === 'Debug' || value == 'Release') {
- g_crossDashboardState['testType'] = 'layout-tests';
- g_crossDashboardState[key] = value;
- return true;
- } else
- return false;
-
default:
return handleValidHashParameter(key, value);
}
@@ -213,7 +205,6 @@
group: '@ToT - chromium.org',
showAllRuns: false,
testType: 'layout-tests',
- buildDir: '',
useTestData: false,
}
@@ -433,14 +424,7 @@
var g_defaultBuilderName, g_builders;
function initBuilders()
{
- if (g_crossDashboardState.buildDir) {
- // If buildDir is set, point to the results.json in the local tree. Useful for debugging changes to the python JSON generator.
- g_defaultBuilderName = 'DUMMY_BUILDER_NAME';
- g_builders = {'DUMMY_BUILDER_NAME': ''};
- var loc = document.location.toString();
- var offset = loc.indexOf('webkit/');
- } else
- currentBuilderGroup().setup();
+ currentBuilderGroup().setup();
}
var g_resultsByBuilder = {};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
