[web2py] Re: format zero IS_IN_DB

2010-02-05 Thread villas
If I've understood the arguments correctly, I think there are 3 good reasons to keep as-is: 1. We should assume the average user to be as lazy as possible and make as few clicks as they can. This means that with default=None the first option will often be passively selected. i.e. many of your u

[web2py] Re: format zero IS_IN_DB

2010-02-05 Thread Iceberg
I also support zero=None, and it is not difficult for me to decide. 1. From the logical point of view, when saying IS_IN_DB(...) or IS_IN_SET(...), it should generate a list that actually is in the set/ db, and nothing more. Besides, this is the way it worked before zero=something is initially inv

Re: [web2py] Re: format zero IS_IN_DB

2010-02-04 Thread Thadeus Burgess
This is a difficult to decide. For me it is both ways. Since half of my forms require zero=None and the other half require zero='', either way it goes there will be no option that is more "convenient" for my development. I stand in support of zero=None. Web2py is a data/business logic oriented fra

Re: [web2py] Re: format zero IS_IN_DB

2010-02-04 Thread Jonathan Lundell
On Feb 4, 2010, at 7:34 AM, mdipierro wrote: > Mind that currently zero='' should be interpreted as zero='(please > choose a value)'. the value '' is not in the db and will not pass > validation. It s just a place holder. Only if > IS_NULL_OR(IS_IN_DB(...zero='')) then the value '' can pass > vali

[web2py] Re: format zero IS_IN_DB

2010-02-04 Thread mdipierro
Mind that currently zero='' should be interpreted as zero='(please choose a value)'. the value '' is not in the db and will not pass validation. It s just a place holder. Only if IS_NULL_OR(IS_IN_DB(...zero='')) then the value '' can pass validation. On Feb 4, 9:25 am, Jonathan Lundell wrote: > O

Re: [web2py] Re: format zero IS_IN_DB

2010-02-04 Thread Jonathan Lundell
On Feb 4, 2010, at 7:08 AM, mdipierro wrote: > I do not really have an opinion on this. I am only reluctant to > changes in behavior. > Anyway, I am prepared to make this change (zero=None by default). I > would like to know that all major contributors are on board so that > you can answer the ema

[web2py] Re: format zero IS_IN_DB

2010-02-04 Thread mdipierro
I do not really have an opinion on this. I am only reluctant to changes in behavior. Anyway, I am prepared to make this change (zero=None by default). I would like to know that all major contributors are on board so that you can answer the emails when users complain instead of me. ;-) Anybody who

[web2py] Re: format zero IS_IN_DB

2010-02-04 Thread DenesL
Any more pros/cons on this? Now is the time to weigh in your opinion. -- You received this message because you are subscribed to the Google Groups "web2py-users" group. To post to this group, send email to web...@googlegroups.com. To unsubscribe from this group, send email to web2py+unsubscr..

[web2py] Re: format zero IS_IN_DB

2010-02-02 Thread DenesL
^bump^ -- You received this message because you are subscribed to the Google Groups "web2py-users" group. To post to this group, send email to web...@googlegroups.com. To unsubscribe from this group, send email to web2py+unsubscr...@googlegroups.com. For more options, visit this group at http:

Re: [web2py] Re: format zero IS_IN_DB

2010-01-30 Thread Thadeus Burgess
Excellent suggestion on adding the comments with a link to the discussion thread Iceberg -Thadeus On Sat, Jan 30, 2010 at 2:07 AM, Iceberg wrote: > When saying "some people ask for zero=None, some for zero='', some for > zero='Please choose a value'", ok, I am the one who once suggest the >

[web2py] Re: format zero IS_IN_DB

2010-01-30 Thread Iceberg
When saying "some people ask for zero=None, some for zero='', some for zero='Please choose a value'", ok, I am the one who once suggest the recent zero='' change, in this thread: https://groups.google.com/group/web2py/browse_frm/thread/7a5154c377c9eec3 But hey, I think I made myself clear in tha

[web2py] Re: format zero IS_IN_DB

2010-01-29 Thread mdipierro
I think the point is: is it better to generate a validation error message when a choice is not selected or, by default, select always the first choice? Are you sure that the problem is with the presence of a blank option and not with the wrong error associated to it? On Jan 29, 9:55 am, Thadeus Bu

Re: [web2py] Re: format zero IS_IN_DB

2010-01-29 Thread Thadeus Burgess
+1 supporting DenesL argument. (but we already know this) note. default. breaks app. we like the feature but it shouldn't break an app no reason to have to specifically DISABLE something that hasn't existed in web2py before ( you know, the empty select or "please choose a value" breaks my app

Re: [web2py] Re: format zero IS_IN_DB

2010-01-29 Thread Jonathan Lundell
Yes, the option is important. But the case for a default of None is pretty convincing. On 1/29/10, mdipierro wrote: > Let's hear a few more opinions. I don't just want to say no. The > problem is that we had this discussion already and people insisted > such option should be there. > > Massimo >

[web2py] Re: format zero IS_IN_DB

2010-01-29 Thread mdipierro
Let's hear a few more opinions. I don't just want to say no. The problem is that we had this discussion already and people insisted such option should be there. Massimo On Jan 29, 9:31 am, DenesL wrote: > I must insist. > The point is that IS_IN_DB and IS_IN_SET now show a spurious empty > optio

[web2py] Re: format zero IS_IN_DB

2010-01-29 Thread DenesL
I must insist. The point is that IS_IN_DB and IS_IN_SET now show a spurious empty option by default. The keyword here is default. If you want to introduce a 'choose a value" option you should do it explicitly and 'at your own risk', the risk being that it creates an option that when selected will

[web2py] Re: format zero IS_IN_DB

2010-01-29 Thread mdipierro
There is no way to please everybody here. some people ask for zero=None, some for zero='', some for zero='Please choose a value'. There is no right or wrong. I think we should leave the default as is ('', we changed it twice already) and you configure it as needed. Massimo On Jan 29, 9:00 am, Den

[web2py] Re: format zero IS_IN_DB

2010-01-29 Thread DenesL
-- You received this message because you are subscribed to the Google Groups "web2py-users" group. To post to this group, send email to web...@googlegroups.com. To unsubscribe from this group, send email to web2py+unsubscr...@googlegroups.com. For more options, visit this group at http://grou

Re: [web2py] Re: format zero IS_IN_DB

2010-01-28 Thread Thadeus Burgess
My thoughts exactly :) -Thadeus On Thu, Jan 28, 2010 at 12:55 PM, DenesL wrote: > Thanks, I've seen it. > > The problem with format and IS_IN_DB can be easily fixed in sql.py but > I would be against setting the default of zero to '' in IS_IN_DB and > IS_IN_SET if it creates an empty option

[web2py] Re: format zero IS_IN_DB

2010-01-28 Thread DenesL
Thanks, I've seen it. The problem with format and IS_IN_DB can be easily fixed in sql.py but I would be against setting the default of zero to '' in IS_IN_DB and IS_IN_SET if it creates an empty option in the dropdown. zero seems to have been introduced to display a "choose a value" kind of messa