here.
The binaries:
http://homes.ourproject.org/~vjrj/otros/patch-socketio.tgz
Diffs
-
/.classpath 1187538
/build.xml 1187538
/src/org/waveprotocol/box/server/robots/agent/passwd/PasswordRobot.java
1187538
/src/org/waveprotocol/box/server/rpc/ServerRpcProvider.java 1187538
/sr
? because I don't know the new usernames here.
The binaries:
http://homes.ourproject.org/~vjrj/otros/patch-socketio.tgz
Diffs
-
/.classpath 1187538
/build.xml 1187538
/src/org/waveprotocol/box/server/robots/agent/passwd/PasswordRobot.java
1187538
/src/org/waveprotocol/box/serve
make this patch
more clear.
Yuri, can you add more reviewers? because I don't know the new usernames here.
The binaries:
http://homes.ourproject.org/~vjrj/otros/patch-socketio.tgz
Diffs
-
/.classpath 1187538
/build.xml 1187538
/src/org/waveprotocol/box/server/robots/agent/p
now, I did not removed use_socketio server parameter to make this patch
more clear.
Yuri, can you add more reviewers? because I don't know the new usernames here.
The binaries:
http://homes.ourproject.org/~vjrj/otros/patch-socketio.tgz
Diffs (updated)
-
/.classpath 1187587
/sr
ion=XXX" makes it work, but I
> > don't know if it's due to the move to 8.0.0 or not (didn't try before
> > applying the patch).
New patch with your comments.
I've also updated socket-io to the git version (I couldn't patched correctly
these days). I
Chrome 16-dev and Firefox 7.0.1.
> >
> > There's also an issue at sign-in: when hitting "sign in", you're redirected
> > to .../;jsession=XXX which displays a directory listing for the root (i.e.
> > static/ and webclient/), removing the ";jsessi
> On 2011-10-24 03:16:05, Yuri Zelikov wrote:
> > So, is the patch ready?
Yes...
- vjrj
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2533/#r
removed use_socketio server parameter to make this patch
more clear.
Yuri, can you add more reviewers? because I don't know the new usernames here.
The binaries:
http://homes.ourproject.org/~vjrj/otros/patch-socketio.tgz
Diffs (updated)
-
/.classpath 1187587
/src/org/waveprotoco
oyer wrote:
> > /third_party/runtime/socketio/README.google, line 2
> > <https://reviews.apache.org/r/2533/diff/3/?file=52637#file52637line2>
> >
> > Same here: use the commit SHA-1 from your GitHub repo?
Same...
- vjrj
cannot test it. Maybe if you have time you can add a test in
EventGeneratorTest.
- vjrj
On 2011-11-23 23:13:59, Yuri Zelikov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apach
> On 2011-11-25 15:44:55, Yuri Zelikov wrote:
> > Unless anyone objects during the next 24 hoours, I will commit this patch.
Sorry, I was looking your review but I'm not familiarized with that part of
code to give a solid feedback. Anyway decoupling sounds good t
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3864/#review5022
---
Ship it!
Tested. LGTM
- vjrj
On 2012-02-11 13:30:37, Yuri Zelikov
/4234/diff
Testing
---
Tested in FF and chrome.
Thanks,
vjrj
> On 2012-04-07 14:16:53, Michael MacFadden wrote:
> > Is this still hanging out there?
No. Yuri fixed that with this patch.
- vjrj
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.o
ndexer.java
<https://reviews.apache.org/r/4774/#comment16366>
License also...
- vjrj
On 2012-05-01 10:50:16, Yuri Zelikov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&g
perly.
- vjrj
On 2012-05-03 18:04:29, Ali Lown wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4994/
> ---
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4774/#review7551
---
Ship it!
LGTM
- vjrj
On 2012-05-04 07:29:12, Yuri Zelikov wrote
/wavepanel/impl/toolbar/LinkerHelper.java
PRE-CREATION
Diff: https://reviews.apache.org/r/5048/diff
Testing
---
Tested in ff and in chrome.
Thanks,
vjrj
/wavepanel/impl/toolbar/EditToolbar.java
eb8402c
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/LinkerHelper.java
PRE-CREATION
Diff: https://reviews.apache.org/r/5048/diff
Testing
---
Tested in ff and in chrome.
Thanks,
vjrj
/Model.gwt.xml
@@ -58,6 +58,8 @@
+
+
New review or can we fix it, in this same review?
- vjrj
On 2012-05-08 17:29:21, Yuri Zelikov wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
/waveprotocol/wave/client/wavepanel/impl/toolbar/EditToolbar.java
eb8402c
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/LinkerHelper.java
PRE-CREATION
Diff: https://reviews.apache.org/r/5048/diff
Testing
---
Tested in ff and in chrome.
Thanks,
vjrj
> On 2012-05-08 17:58:40, vjrj wrote:
> > Now works great, but still exist some errors in the console (but are not
> > related). Can be fixed with excludes in gwt.xml files, like:
> >
> > diff --git a/src/org/waveprotocol/wave/model/Model.gwt.xml
> >
/client/wavepanel/impl/toolbar/EditToolbar.java
eb8402c
src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/LinkerHelper.java
PRE-CREATION
Diff: https://reviews.apache.org/r/5048/diff
Testing
---
Tested in ff and in chrome.
Thanks,
vjrj
l+K without success because the patch is not committed :)
Any problem to commit this?
- vjrj
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5048/#review7847
--
://reviews.apache.org/r/5180/diff
Testing
---
Some tests with "ant waveharness-hosted"
Thanks,
vjrj
/5252/diff
Testing
---
ant waveharness-hosted, and also a full test of WIAB with client compilation,
etc.
Thanks,
vjrj
Github user vjrj commented on the issue:
https://github.com/apache/incubator-wave/pull/24
Thanks indeed Pablo for taking care of this important bug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vjrj commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/24#discussion_r118838375
--- Diff:
wave/src/main/java/org/waveprotocol/box/server/frontend/WaveViewSubscription.java
---
@@ -154,7 +155,15 @@ public synchronized void
28 matches
Mail list logo
