Github user pablojan commented on the issue:
https://github.com/apache/incubator-wave/pull/19
My apologies for the delayed review.
I tried the PR and LGTM:
Following tasks ran successfully: testAll, jar, run, createDist
I performed following tests:
Extract
I tried the PR. LGTM:
Following tasks ran successfully: *testAll, jar, run, createDist*
My test was:
Extracted *distributions/wave-0.4.2.zip*, and ran* ./bin/wave*
Created an user and a new wave. Everything worked Ok. Text editor worked in
Chrome. User avatars didn't show.
Server stopped (Ctrl+
Github user vega113 commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/19#discussion_r106804336
--- Diff:
wave/src/main/java/org/apache/wave/box/server/rpc/InitialsAvatarsServlet.java
---
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache
Github user vega113 commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/19#discussion_r106805040
--- Diff: wave/dist/run-server.bat ---
@@ -1,23 +0,0 @@
-echo off
--- End diff --
It would be great if we could update the run instruc
Github user vega113 commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/19#discussion_r106786459
--- Diff:
wave/src/main/java/org/apache/wave/box/server/rpc/InitialsAvatarsServlet.java
---
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache
Github user wisebaldone commented on a diff in the pull request:
https://github.com/apache/incubator-wave/pull/19#discussion_r106806350
--- Diff:
wave/src/main/java/org/apache/wave/box/server/rpc/InitialsAvatarsServlet.java
---
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apa
