I tried the PR. LGTM:

Following tasks ran successfully: *testAll, jar, run, createDist*

My test was:

Extracted *distributions/wave-0.4.2.zip*, and ran* ./bin/wave*
Created an user and a new wave. Everything worked Ok. Text editor worked in
Chrome. User avatars didn't show.

Server stopped (Ctrl+C)
Changed following props in *config/reference.app*,

*delta_store_type : mongodb*
*profile_fetcher_type : gravatar*


Ran again
*./bin/wave*
Created new wave. Everything worked Ok, User avatars are shown now
(Gravatar). Wavelets delta appears in mongoDB.

It might be good to add the "*./bin/wave" *step in the README.

Thanks Evan.


2017-03-18 18:04 GMT+01:00 Yuri Z <vega...@gmail.com>:

> Will do.
>
> On Sat, Mar 18, 2017 at 5:20 PM Evan Hughes <wisebald...@apache.org>
> wrote:
>
> > Well im going to be starting my tasks soon, but would appreciate it if
> > someone can review the current pull request outstanding so that i can fix
> > it if need be.
> >
> > On Mon, 13 Mar 2017 at 00:03 Yuri Z <vega...@gmail.com> wrote:
> >
> > > Evan, thanks for compiling the TODOs.
> > > @Upayavira - can you please review the list and add items in case some
> > are
> > > missing?
> > >
> > >
> > > On Sun, Mar 12, 2017 at 2:59 PM Evan Hughes <ehu...@gmail.com> wrote:
> > >
> > > > Ive hoped on IRC using riot.im so I should be available around the
> > > clock.
> > > > If you have time it turns out my pull request is still waiting on
> > github,
> > > >
> > > > On Sun, 12 Mar 2017 at 22:20 Pablo Ojanguren <pablo...@gmail.com>
> > wrote:
> > > >
> > > > > Hi Evan, you right regarding SwellRT, how it is going to be
> > integrated
> > > or
> > > > > exploited in the Wave's "master" branch is still a decision to be
> > made.
> > > > > I've got the responsibility to explain to Wave's community what is
> > the
> > > > > current status of SwellRT in order to address a decision. Please
> give
> > > me
> > > > a
> > > > > couple of days to write down a summary.
> > > > >
> > > > > I think it is good to move forward the graduation process at the
> same
> > > > time.
> > > > >
> > > > > Which communication channel are we going to use to work in daily
> > stuff
> > > of
> > > > > TODO task? IRC?
> > > > >
> > > > > 2017-03-12 13:00 GMT+01:00 Evan Hughes <ehu...@gmail.com>:
> > > > >
> > > > > > Cwiki link: https://cwiki.apache.org/confluence/display/WAVE/
> > > > > > Graduation+Todo
> > > > > >
> > > > > >
> > > > > > Really need to know about what's happening with swellrt, are we
> > that
> > > > > > communities new hub for development, is the swellrt source now
> the
> > > > > > responsability of the apache wave community to update and
> > distribute.
> > > > If
> > > > > it
> > > > > > is ild like to start getting a move on with that into integrating
> > it
> > > > and
> > > > > > setting up all the structures for it.
> > > > > >
> > > > > > On Sun, 12 Mar 2017 at 15:28 Evan Hughes <wisebald...@apache.org
> >
> > > > wrote:
> > > > > >
> > > > > > > All good points but I recommend we continue along the path and
> > deal
> > > > > with
> > > > > > > the issues as they arise. Ill make the intiial wiki pega this
> > > > afternoon
> > > > > > and
> > > > > > > some of the tickets and assign to those who have put there hand
> > up
> > > > for
> > > > > > them.
> > > > > > >
> > > > > > > What are the stages of the SwellRT code Base and how is it
> > > > integrating
> > > > > > > into our project? Ive always been slightly confused at where it
> > is
> > > > > gonna
> > > > > > > sit repo wise and project wise.
> > > > > > >
> > > > > > >
> > > > > > > ~ Evan
> > > > > > >
> > > > > > >
> > > > > > > On Sun, 12 Mar 2017 at 07:10 Upayavira <u...@odoko.co.uk> wrote:
> > > > > > >
> > > > > > > This, Michael, is the crucial point. To graduate, we must have
> a
> > > > > minimum
> > > > > > > of 5 PMC members (3, plus a couple of spares). To be a PMC
> > member,
> > > > > > > someone must already be on the PPMC, and must be prepared to
> > > > > participate
> > > > > > > in votes for new committers/PMC members and to assist with
> > > reviewing
> > > > > > > release candidates. Those are the primary responsibilities of a
> > PMC
> > > > > > > member (see ASF docs for a fuller list).
> > > > > > >
> > > > > > > If we cannot get 5 people to agree to taking on that role, we
> > might
> > > > as
> > > > > > > well stop worrying about everything else.
> > > > > > >
> > > > > > > Beyond that, we need to look at any incubator checklists, e.g.
> > > > ticking
> > > > > > > licensing boxes, making sure we've recorded who is on the PPMC,
> > > etc -
> > > > > > > anything that the Incubator PMC will use to understand what we
> > are
> > > up
> > > > > to
> > > > > > > when making their decision as to whether to accept our proposal
> > to
> > > > > > > become a TLP.
> > > > > > >
> > > > > > > Whether we have a Dockerfile, or have too many dependencies,
> etc,
> > > is,
> > > > > > > from the perspective of graduation, irrelevant.
> > > > > > >
> > > > > > > Upayavira
> > > > > > >
> > > > > > > I am not sure we can yet meet this cri
> > > > > > >
> > > > > > > On Sat, 11 Mar 2017, at 03:57 PM, Michael MacFadden wrote:
> > > > > > > > Hello all,
> > > > > > > >
> > > > > > > > I know there has been some email traffic on this recently,
> but
> > I
> > > > > think
> > > > > > we
> > > > > > > > should also prepare a little section in the wiki that talks
> > about
> > > > the
> > > > > > > > people in the project.  Who would be the committers, the PMC,
> > > etc.
> > > > > > > > Essentially who are going to be the initial active
> participants
> > > of
> > > > > the
> > > > > > > > TLP. We have a lot of committers here from 4 years ago that
> > have
> > > > > moved
> > > > > > on
> > > > > > > > to other things and don’t have time to.. My understanding in
> > > > general
> > > > > > for
> > > > > > > > a TLP is that committers don’t always equal PMC; but that
> for a
> > > > small
> > > > > > set
> > > > > > > > of committers that may be the case.
> > > > > > > >
> > > > > > > > Regardless, I think one task is to identify who will really
> be
> > > part
> > > > > of
> > > > > > > > the TLP and in what capacity.
> > > > > > > >
> > > > > > > > I would be happing to work on this though interaction on the
> > > > mailing
> > > > > > > > list.
> > > > > > > >
> > > > > > > > ~Michael
> > > > > > > >
> > > > > > > > On 3/11/17, 2:40 AM, "Pablo Ojanguren" <pablo...@gmail.com>
> > > wrote:
> > > > > > > >
> > > > > > > >     That todo list LGTM
> > > > > > > >     Thanks Evan
> > > > > > > >
> > > > > > > >     2017-03-10 1:04 GMT+01:00 Evan Hughes <ehu...@gmail.com
> >:
> > > > > > > >
> > > > > > > >     > Hello all,
> > > > > > > >     >
> > > > > > > >     > I think it's time for us to make a fixed set of tasks
> we
> > > want
> > > > > > done
> > > > > > > before
> > > > > > > >     > we go for graduation.
> > > > > > > >     >
> > > > > > > >     > To start off the list we must complete all the usual
> org
> > > > tasks.
> > > > > > > This
> > > > > > > >     > includes license checking, notice checks, crypto
> notice.
> > > > > > > >     >
> > > > > > > >     > Please respond to this with dot points of tasks you
> think
> > > > > should
> > > > > > > be on our
> > > > > > > >     > todos before grad and they will latter be compiled into
> > our
> > > > > > > confluence for
> > > > > > > >     > the time being (maybe on website in the future). This
> > will
> > > > then
> > > > > > > transition
> > > > > > > >     > to issues and may be assigned to individuals to
> complete
> > > > before
> > > > > > > the next
> > > > > > > >     > report.
> > > > > > > >     >
> > > > > > > >     > Just to state clearly, anyone is able to make a
> > suggestion,
> > > > > don't
> > > > > > > limit
> > > > > > > >     > suggestions to small tasks that are able to be
> completed
> > > > before
> > > > > > > the next
> > > > > > > >     > Incubator report.
> > > > > > > >     >
> > > > > > > >     >
> > > > > > > >     > Todo List:
> > > > > > > >     >
> > > > > > > >     > * Publish the svg of logo on website.
> > > > > > > >     > * Update incubator logo to use the new one (will be
> > > released
> > > > > > > shortly).
> > > > > > > >     > * Remove any unesscary dependencies in repo.
> > > > > > > >     > * Vote to decide on keeping the android client or to
> > purge
> > > > the
> > > > > > > repo.
> > > > > > > >     > * Make an updated binary release after all changes
> made.
> > > > > > > >     > * Clean the repository.
> > > > > > > >     > * Docker file.
> > > > > > > >     >
> > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Reply via email to