Stuff and mocking things

2016-11-24 Thread Evan Hughes
Hey all, Been working on removing old dependencies and updating dependencies as can be seen here https://github.com/apache/incubator-wave/tree/fix/dependendices-2016 . It seems we have to mocking lib's in use, if anyone is good with mockito would you kindly help in transiting the tests with the ot

Re: Stuff and mocking things

2016-11-24 Thread Yuri Z
Great news, thanks Evan! Regarding mockito - what are the issues? On Thu, Nov 24, 2016 at 1:20 PM Evan Hughes wrote: > Hey all, > > Been working on removing old dependencies and updating dependencies as can > be seen here > https://github.com/apache/incubator-wave/tree/fix/dependendices-2016 . I

Re: Stuff and mocking things

2016-11-24 Thread Evan Hughes
We shouldn't have 2 mocking libraries and mockito is the superior one since its continually maintained. We can even do fancy things like this http://google.github.io/gwtmockito/ in the future to aid in having the gwt js library well tested. On Thu, 24 Nov 2016 at 21:50 Yuri Z wrote: > Great news

Re: Stuff and mocking things

2016-11-24 Thread Yuri Z
Sure, I guess I can help with this. How we coordinate to ensure we don't work on the same tests? Would you like to send me a few test class names to work on? On Thu, Nov 24, 2016 at 1:59 PM Evan Hughes wrote: > We shouldn't have 2 mocking libraries and mockito is the superior one since > its con

Re: Bad links to waveinabox.net

2016-11-24 Thread Yuri Z
Ok, I ll find the time to remove broken/invalid links. On Tue, Oct 4, 2016 at 11:21 PM Zachary Yaro wrote: > WaveInABox.net used to host an Apache Wave demo instance, but presumably > the domain expired and someone else bought it up. Those links were correct > at the time they were added, but t

Re: [GitHub] incubator-wave issue #17: Update xerces, gwt and guava dependencies

2016-11-24 Thread Yuri Z
By the way, maybe we should add pablo as committer? On Tue, Nov 1, 2016 at 1:02 PM wrote: > Also GWT 2.8 has been released xD > > googlewebtoolkit.blogspot.com.es/2016/10/gwt-28-released.html?m=1 > > El 1 nov. 2016 4:55 a. m., wisebaldone escribió: > > Github user wisebaldone commented on the i

Re: Stuff and mocking things

2016-11-24 Thread Evan Hughes
incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/IdempotentSchedulerTest.java incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/knobs/ControllerTest.java incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/testing/FakeTimerServiceT

Re: [GitHub] incubator-wave issue #17: Update xerces, gwt and guava dependencies

2016-11-24 Thread Evan Hughes
increasing the committer member count wouldn't be a bad idea :P On Thu, 24 Nov 2016 at 22:06 Yuri Z wrote: > By the way, maybe we should add pablo as committer? > > On Tue, Nov 1, 2016 at 1:02 PM wrote: > > > Also GWT 2.8 has been released xD > > > > googlewebtoolkit.blogspot.com.es/2016/10/gwt

Re: Stuff and mocking things

2016-11-24 Thread Yuri Z
I ll start with SchedulerTest.java On Thu, Nov 24, 2016 at 2:13 PM Evan Hughes wrote: > > incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/IdempotentSchedulerTest.java > > incubator-wave/wave/src/test/java/org/waveprotocol/wave/client/scheduler/knobs/ControllerTest.java >

Re: [GitHub] incubator-wave issue #17: Update xerces, gwt and guava dependencies

2016-11-24 Thread pablojan
Thanks guys! ;) El 24 nov. 2016 1:22 p. m., Evan Hughes escribió: increasing the committer member count wouldn't be a bad idea :P On Thu, 24 Nov 2016 at 22:06 Yuri Z wrote: > By the way, maybe we should add pablo as committer? > > On Tue, Nov 1, 2016 at 1:02 PM wrote: > > > Also GWT 2.8 has