Re: Review Request 16322: full text search (with known issue of solr-bot output highlight)

2013-12-19 Thread Frank R.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16322/ --- (Updated Dec. 19, 2013, 8:23 p.m.) Review request for wave, Ali Lown, Vicente J

Re: Review Request 16322: full text search (with known issue of solr-bot output highlight)

2013-12-19 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16322/#review30695 --- Thanks! Can you please address the comments by closing them where do

Re: Review Request 16359: full text search

2013-12-19 Thread Ali Lown
NP. Another minor thing: For the current review (16322), could you please put "WAVE-311" in the bugs field, so that it is properly associated with that JIRA ticket. (The ticket gets auto-updated etc.) Thanks. Ali On 19 December 2013 13:14, Frank R. wrote: > Thank you~ > > > > On Thu, Dec 19, 2

Re: Review Request 16322: full text search (with known issue of solr-bot output highlight)

2013-12-19 Thread Frank R.
I hate to refuse you. But, i'm afraid this is the best I can do at the moment. I need more time and to learn more stuff before I can come back and address all the remaining comments. Nevertheless, I'd like to take the challenge. I'm going to submit another patch update in a few minutes. Thank yo

Re: Review Request 16359: full text search

2013-12-19 Thread Frank R.
Gladly~ On Thu, Dec 19, 2013 at 9:17 PM, Ali Lown wrote: > NP. > > Another minor thing: For the current review (16322), could you please put > "WAVE-311" in the bugs field, so that it is properly associated with that > JIRA ticket. (The ticket gets auto-updated etc.) > > Thanks. > Ali > > > On

Re: Review Request 16322: full text search (with known issue of solr-bot output highlight)

2013-12-19 Thread Frank R.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16322/ --- (Updated Dec. 19, 2013, 9:34 p.m.) Review request for wave, Ali Lown, Vicente J

Re: Review Request 16322: full text search (with known issue of solr-bot output highlight)

2013-12-19 Thread Frank R.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16322/ --- (Updated Dec. 19, 2013, 10:11 p.m.) Review request for wave, Ali Lown, Vicente

Re: Review Request 16322: full text search (with known issue of solr-bot output highlight)

2013-12-19 Thread Frank R.
Does someone know how to get the annotation out of a ReadableWaveletData? I can use that to get the conv/title, and display it as link text in solr-bot search results. Thanks. On Thu, Dec 19, 2013 at 9:05 PM, Yuri Zelikov wrote: >This is an automatically generated e-mail. To reply, visit: >

Re: Setting up Wave for client development (my experience setting up on WindowsXP)

2013-12-19 Thread Thomas Wrobel
Still cant seem to get the GWT hosted mode working. I am 95% sure the server is fine. Running "ant run-server" and going to localhost:9898 means I can see and use the webclient. Have to keep making new accounts as the old one shiny-ed, but I guess that's just a normal bug. Running "ant hosted" st

Re: Setting up Wave for client development (my experience setting up on WindowsXP)

2013-12-19 Thread Frank R.
What is the port of 8001? On Thu, Dec 19, 2013 at 11:45 PM, Thomas Wrobel wrote: > Still cant seem to get the GWT hosted mode working. > > I am 95% sure the server is fine. Running "ant run-server" and going to > localhost:9898 means I can see and use the webclient. Have to keep making > new ac

Re: Setting up Wave for client development (my experience setting up on WindowsXP)

2013-12-19 Thread Thomas Wrobel
Dunno. the "address=" field specifys it, dunno what it refers too. ~~~ Thomas & Bertines online review show: http://randomreviewshow.com/index.html Try it! You might even feel ambivalent about it :) On 20 December 2013 00:49, Frank R. wrote: > What is the port of 8001? > > > On Thu, Dec 19, 20

Re: Setting up Wave for client development (my experience setting up on WindowsXP)

2013-12-19 Thread Ali Lown
The purpose of "" is adding support for using a remote debugger. It setups up the JDB client at localhost:8001, so you can then attach JDB at will. (See: http://publib.boulder.ibm.com/infocenter/javasdk/v6r0/index.jsp?topic=%2Fcom.ibm.java.doc.user.aix64.60%2Fuser%2Fjdb.html) Ali On 20 Decembe

Re: Setting up Wave for client development (my experience setting up on WindowsXP)

2013-12-19 Thread Frank R.
Did you notice there was a little icon (as a gray gwt toolbox) to the right of your chrome address bar? 1. Click it, and you'll see a button, Update Your Configuration. 2. Click on the button, and you'll see a page, GWT Developer Plugin Options. 3. Include a web and code server pair. I

Re: Setting up Wave for client development (my experience setting up on WindowsXP)

2013-12-19 Thread Frank R.
You don't need this at all. http://localhost:9898"/> On Tue, Dec 17, 2013 at 1:26 AM, Yuri Z wrote: > Try to add the startupUrl like this: > > description="Runs the hosted mode server, for debugging the GWT > client in a JVM."> > classname="com.google.gwt.dev.DevMode"> >

Re: Setting up Wave for client development (my experience setting up on WindowsXP)

2013-12-19 Thread Frank R.
It shouldn't be difficult to figure out how to make a debug/run configuration for eclipse by studying the ant target, hosted-gwt. See build.xml On Fri, Dec 20, 2013 at 9:14 AM, Frank R. wrote: > Did you notice there was a little icon (as a gray gwt toolbox) to the > right of your chrome address

Re: Setting up Wave for client development (my experience setting up on WindowsXP)

2013-12-19 Thread Frank R.
What's the port for? Can I attach eclipse debug a gwt hosted server (started with ant hosted-gwt) by that port? Thanks. On Fri, Dec 20, 2013 at 8:08 AM, Ali Lown wrote: > The purpose of > " value="-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=8001"/>" > is adding support for usi

Re: Review Request 16322: full text search (with known issue of solr-bot output highlight)

2013-12-19 Thread Ali Lown
First a few random things from a quick glance over your code (I could put them on ReviewBoard, or here is fine too): - Please use IdConstants,X and DocumentConstants.X - This will also encourage you to use IdUtil's methods - which will 'correctly' distinguish conversation wavelets, blip documents e

Re: Review Request 16322: full text search (with known issue of solr-bot output highlight)

2013-12-19 Thread Frank R.
Hi Ali Please read my inline comments. On Fri, Dec 20, 2013 at 9:40 AM, Ali Lown wrote: > First a few random things from a quick glance over your code (I could put > them on ReviewBoard, or here is fine too): > - Please use IdConstants,X and DocumentConstants.X > - This will also encourage you