Gladly~
On Thu, Dec 19, 2013 at 9:17 PM, Ali Lown <a...@lown.me.uk> wrote: > NP. > > Another minor thing: For the current review (16322), could you please put > "WAVE-311" in the bugs field, so that it is properly associated with that > JIRA ticket. (The ticket gets auto-updated etc.) > > Thanks. > Ali > > > On 19 December 2013 13:14, Frank R. <renfeng...@gmail.com> wrote: > >> Thank you~ >> >> >> >> On Thu, Dec 19, 2013 at 7:29 PM, Ali Lown <a...@lown.me.uk> wrote: >> >>> The same one that you based the original patch on. >>> >>> Presumably, the history of that branch now has multiple commits in it, >>> so you will need to squash them down again to use git patch, or you could >>> use git diff against the same common commit you used last time. >>> >>> Ali >>> >>> >>> On 19 December 2013 02:09, Frank R. <renfeng...@gmail.com> wrote: >>> >>>> Which commit shall I base the diff on? Thanks~ >>>> >>>> >>>> On Thu, Dec 19, 2013 at 9:53 AM, Ali Lown <a...@lown.me.uk> wrote: >>>> >>>>> This is an automatically generated e-mail. To reply, visit: >>>>> https://reviews.apache.org/r/16359/ >>>>> >>>>> Thanks for doing this work, but please don't create a new review request >>>>> for the same thing. >>>>> >>>>> Could you please close this review request, and "update diff" on the >>>>> other request with the latest diff. >>>>> >>>>> >>>>> - Ali Lown >>>>> >>>>> On December 19th, 2013, 1:42 a.m. UTC, Frank R. wrote: >>>>> Review request for wave, Ali Lown, Vicente J. Ruiz Jurado, and Yuri >>>>> Zelikov. >>>>> By Frank R.. >>>>> >>>>> *Updated Dec. 19, 2013, 1:42 a.m.* >>>>> *Repository: * wave >>>>> Description >>>>> >>>>> For details (issues and commits):https://github.com/renfeng/wave >>>>> >>>>> Testing >>>>> >>>>> tests on search box >>>>> >>>>> * in:inbox >>>>> * (empty) for all, including waves shared in the domain >>>>> * with:@ >>>>> * (free texts) >>>>> >>>>> tests on solr-bot >>>>> >>>>> * single word >>>>> * phrase (quoted with double quotation marks) >>>>> * syntax applicable to search box >>>>> >>>>> Diffs >>>>> >>>>> - run-export.sh (d2cddb7) >>>>> - run-import.sh (45fff8a) >>>>> - server.config.example (19ba8b2) >>>>> - src/org/waveprotocol/box/server/SearchModule.java (2de0ef9) >>>>> - src/org/waveprotocol/box/server/ServerMain.java (b50454d) >>>>> - src/org/waveprotocol/box/server/robots/agent/search/SolrRobot.java >>>>> (PRE-CREATION) >>>>> - >>>>> src/org/waveprotocol/box/server/robots/agent/welcome/WelcomeRobot.java >>>>> (2735940) >>>>> - >>>>> src/org/waveprotocol/box/server/waveserver/SimpleSearchProviderImpl.java >>>>> (ee7093f) >>>>> - >>>>> src/org/waveprotocol/box/server/waveserver/SolrSearchProviderImpl.java >>>>> (PRE-CREATION) >>>>> - src/org/waveprotocol/box/server/waveserver/SolrWaveIndexerImpl.java >>>>> (PRE-CREATION) >>>>> >>>>> View Diff <https://reviews.apache.org/r/16359/diff/> >>>>> >>>> >>>> >>> >> >
