Re: Review Request: Horizontal lines in the editor

2012-10-21 Thread Vicente J. Ruiz Jurado
> On Oct. 21, 2012, 6:08 p.m., Yuri Zelikov wrote: > > The patch LGTM, but can you please send link to the hr_line.png binary file > > or send it in email? I'm trying to send a new patch following Patrick comments, but for now, I didn't find the way to enforce that hr constraint. I'll try aga

Re: Review Request: Horizontal lines in the editor

2012-10-21 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7364/#review12643 --- The patch LGTM, but can you please send link to the hr_line.png binar

Re: Review Request: Horizontal lines in the editor

2012-10-08 Thread Vicente J. Ruiz Jurado
> On Oct. 1, 2012, 8:57 a.m., Patrick Coleman wrote: > > Hard to tell from reading the code, but out of interest, what happens if > > the line element has content after it? > > e.g. Some textmore text > > in HTML is special as it can't have children (I believe), so this > > might be a contrain

Re: Review Request: Horizontal lines in the editor

2012-10-04 Thread Patrick Coleman
> On Oct. 1, 2012, 8:57 a.m., Patrick Coleman wrote: > > Hard to tell from reading the code, but out of interest, what happens if > > the line element has content after it? > > e.g. Some textmore text > > in HTML is special as it can't have children (I believe), so this > > might be a contrain

Re: Review Request: Horizontal lines in the editor

2012-10-02 Thread Vicente J. Ruiz Jurado
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7364/ --- (Updated Oct. 2, 2012, 9:26 a.m.) Review request for wave, Michael MacFadden, Yu

Re: Review Request: Horizontal lines in the editor

2012-10-02 Thread Vicente J. Ruiz Jurado
> On Oct. 1, 2012, 8:57 a.m., Patrick Coleman wrote: > > Hard to tell from reading the code, but out of interest, what happens if > > the line element has content after it? > > e.g. Some textmore text > > in HTML is special as it can't have children (I believe), so this > > might be a contrain

Re: Review Request: Horizontal lines in the editor

2012-10-01 Thread Patrick Coleman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7364/#review12055 --- Hard to tell from reading the code, but out of interest, what happens

Review Request: Horizontal lines in the editor

2012-09-30 Thread Vicente J. Ruiz Jurado
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7364/ --- Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown. Descript