> On Oct. 1, 2012, 8:57 a.m., Patrick Coleman wrote: > > Hard to tell from reading the code, but out of interest, what happens if > > the line element has content after it? > > e.g. <l t="hr" />Some text<l />more text > > <hr> in HTML is special as it can't have children (I believe), so this > > might be a contraint we want to enforce here too. > > Vicente J. Ruiz Jurado wrote: > Sincerely, I have no idea. It's the first time that I do a patch in this > part of the Wave code so this kind of comments are more than welcome. > > Any suggestion/recommendation of how and where to enforce that? Thanks. > > > > Patrick Coleman wrote: > No worries! Good to see people making changes. For document structure > constraints, > take a look at > org/waveprotocol/wave/model/schema/conversation/ConversationSchemas.java > which defines what schema the XML conversation document can have. > > That said, maybe there's a simpler solution - e.g. instead of having the > line be the hr, have an attribute separator="line" or similar - > then any <line>'s with this can be styled with an appropriate > border-bottom (not entire border). > Similarly, separator="pagebreak" could be used to indicate after which > sections page breaks could be inserted (and maybe have no visual indicators, > or a dotted border-bottom, or something)
Thanks indeed Patrick, it sounds very reasonable. I'll resend the patch with your comments. - Vicente J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7364/#review12055 ----------------------------------------------------------- On Oct. 2, 2012, 9:26 a.m., Vicente J. Ruiz Jurado wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7364/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2012, 9:26 a.m.) > > > Review request for wave, Michael MacFadden, Yuri Zelikov, Ali Lown, and > Patrick Coleman. > > > Description > ------- > > This patch adds <hr/> to the wave editor, fixing part of the WAVE-340 issue. > > So now exists a new button in the EditToolbar for that. > > > This addresses bug WAVE-340. > https://issues.apache.org/jira/browse/WAVE-340 > > > Diffs > ----- > > src/org/waveprotocol/wave/client/editor/Editor.css 58429fb > src/org/waveprotocol/wave/client/editor/content/ContentDocument.java > 528188f > > src/org/waveprotocol/wave/client/editor/content/paragraph/DefaultParagraphHtmlRenderer.java > b49c070 > src/org/waveprotocol/wave/client/editor/content/paragraph/Paragraph.java > e8d01b9 > > src/org/waveprotocol/wave/client/editor/content/paragraph/ParagraphBehaviour.java > 6e48632 > src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditToolbar.css > 8bf9970 > src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditToolbar.java > 3da1588 > > src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditorToolbarResources.java > 5658c12 > > src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/images/edit/hr_line.png > PRE-CREATION > > src/org/waveprotocol/wave/model/schema/conversation/ConversationSchemas.java > e6f54ef > test/org/waveprotocol/wave/model/document/util/LineContainersTest.java > 7cc6466 > > Diff: https://reviews.apache.org/r/7364/diff/ > > > Testing > ------- > > Normal testing with editor. > > > Thanks, > > Vicente J. Ruiz Jurado > >
