Re: Review Request: Fix check-certificates script

2013-06-13 Thread Bruno Gonzalez
> On June 6, 2013, 7:51 p.m., Ali Lown wrote: > > This looks fine. > > > > It is probably worth adding a warning/note that this is only checking one > > of the 3 possible sets of certificates that you could be interested in with > > Wave. > > (Namely, this script only checks the validity of th

Re: Review Request: Fix check-certificates script

2013-06-08 Thread Ali Lown
> On June 6, 2013, 7:51 p.m., Ali Lown wrote: > > This looks fine. > > > > It is probably worth adding a warning/note that this is only checking one > > of the 3 possible sets of certificates that you could be interested in with > > Wave. > > (Namely, this script only checks the validity of th

Re: Review Request: Fix check-certificates script

2013-06-08 Thread Yuri Zelikov
> On June 6, 2013, 7:51 p.m., Ali Lown wrote: > > This looks fine. > > > > It is probably worth adding a warning/note that this is only checking one > > of the 3 possible sets of certificates that you could be interested in with > > Wave. > > (Namely, this script only checks the validity of th

Re: Review Request: Fix check-certificates script

2013-06-08 Thread Ali Lown
> On June 6, 2013, 7:51 p.m., Ali Lown wrote: > > This looks fine. > > > > It is probably worth adding a warning/note that this is only checking one > > of the 3 possible sets of certificates that you could be interested in with > > Wave. > > (Namely, this script only checks the validity of th

Re: Review Request: Fix check-certificates script

2013-06-06 Thread Ali Lown
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11675/#review21538 --- This looks fine. It is probably worth adding a warning/note that th

Review Request: Fix check-certificates script

2013-06-06 Thread Bruno Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11675/ --- Review request for wave. Description --- Fix the check-certificates.sh scr