> On June 6, 2013, 7:51 p.m., Ali Lown wrote: > > This looks fine. > > > > It is probably worth adding a warning/note that this is only checking one > > of the 3 possible sets of certificates that you could be interested in with > > Wave. > > (Namely, this script only checks the validity of the delta signing > > certificates, which are only used for federation).
committed. - Ali ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11675/#review21538 ----------------------------------------------------------- On June 6, 2013, 1:42 p.m., Bruno Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11675/ > ----------------------------------------------------------- > > (Updated June 6, 2013, 1:42 p.m.) > > > Review request for wave. > > > Description > ------- > > Fix the check-certificates.sh script, parsing actual default configuration > files. > Also fix some trailing blank characters. > Additionally, return 0 in case of success, and 1 in case of error (maybe this > can be used in conjunction with other scripts in the future). > > > Diffs > ----- > > check-certificates.sh 68d080c > > Diff: https://reviews.apache.org/r/11675/diff/ > > > Testing > ------- > > Write correct configuration into server.config and server.federation.config > files, run ./check-certificates.sh, check that it returns 0. > Then mess with the config and cert files, run the script again, and check > that it complains and returns != 0. > > > Thanks, > > Bruno Gonzalez > >
