Re: Review Request 38849: Create a pst-src.jar during the build

2015-10-01 Thread Ali Lown
> On Oct. 1, 2015, 2:42 p.m., Ali Lown wrote: > > Ship It! Committed as fdb393268f94986d7d8e31b5258149895efc15b3. - Ali --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38849/#review101232 ---

Re: Review Request 38849: Create a pst-src.jar during the build

2015-10-01 Thread Ali Lown
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38849/#review101232 --- Ship it! Ship It! - Ali Lown On Sept. 29, 2015, 11:56 a.m., Mar

Re: Review Request 38849: Create a pst-src.jar during the build

2015-10-01 Thread Martin Letis
> On Sept. 30, 2015, 10:30 p.m., Ali Lown wrote: > > Patch LGTM. > > > > What is the use case for this pst-src file? Why should we build it as well? Most other dist libs are created as binary+source jar using the "distlib" macrodef in build-macros.xml. The pst.jar artifact is an exception beca

Re: Review Request 38849: Create a pst-src.jar during the build

2015-09-30 Thread Ali Lown
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38849/#review101172 --- Patch LGTM. What is the use case for this pst-src file? Why should