> On Sept. 30, 2015, 10:30 p.m., Ali Lown wrote: > > Patch LGTM. > > > > What is the use case for this pst-src file? Why should we build it as well?
Most other dist libs are created as binary+source jar using the "distlib" macrodef in build-macros.xml. The pst.jar artifact is an exception because it doesn't use the macrodef. Building the -src.jar as well makes sense for consistency, and also it's easier to use the code in an IDE with a -src.jar available. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38849/#review101172 ----------------------------------------------------------- On Sept. 29, 2015, 11:56 a.m., Martin Letis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38849/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2015, 11:56 a.m.) > > > Review request for wave and Ali Lown. > > > Repository: wave > > > Description > ------- > > Create a pst-src.jar during 'dist-pst' > > > Diffs > ----- > > build.xml 893654a > > Diff: https://reviews.apache.org/r/38849/diff/ > > > Testing > ------- > > > Thanks, > > Martin Letis > >
