Re: Review Request 18941: Add GWT superdev mode for waveharness and editor

2014-03-19 Thread Ali Lown
Thanks, On 18 March 2014 19:33, Vicente J. Ruiz Jurado wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18941/ > > On March 9th, 2014, 8:34 p.m. UTC, *Ali Lown* wrote: > > LGTM. > Can I request that you document this new mode in > https://cw

Re: Review Request 18941: Add GWT superdev mode for waveharness and editor

2014-03-18 Thread Vicente J. Ruiz Jurado
> On March 9, 2014, 8:34 p.m., Ali Lown wrote: > > LGTM. > > Can I request that you document this new mode in > > https://cwiki.apache.org/confluence/display/WAVE/Client+Development+Setup > > once you commit this patch? > > Vicente J. Ruiz Jurado wrote: > Off course (Can you grant me permi

Re: Review Request 18941: Add GWT superdev mode for waveharness and editor

2014-03-13 Thread Ali Lown
Vicente, You should be marked as an admin now. Ali On 13 March 2014 23:25, Vicente J. Ruiz Jurado wrote: > > >> On March 9, 2014, 8:34 p.m., Ali Lown wrote: >> > LGTM. >> > Can I request that you document this new mode in >> > https://cwiki.apache.org/confluence/display/WAVE/Client+Development

Re: Review Request 18941: Add GWT superdev mode for waveharness and editor

2014-03-13 Thread Vicente J. Ruiz Jurado
> On March 9, 2014, 8:34 p.m., Ali Lown wrote: > > LGTM. > > Can I request that you document this new mode in > > https://cwiki.apache.org/confluence/display/WAVE/Client+Development+Setup > > once you commit this patch? Off course (Can you grant me permissions?). Commited: 3682cf9146cfc975eea

Re: Review Request 18941: Add GWT superdev mode for waveharness and editor

2014-03-09 Thread Ali Lown
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18941/#review36611 --- Ship it! LGTM. Can I request that you document this new mode in ht

Re: Review Request 18941: Add GWT superdev mode for waveharness and editor

2014-03-08 Thread Vicente J. Ruiz Jurado
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18941/ --- (Updated March 8, 2014, 12:42 p.m.) Review request for wave, Ali Lown, Pablo Oj

Re: Review Request 18941: Add GWT superdev mode for waveharness and editor

2014-03-08 Thread Vicente J. Ruiz Jurado
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18941/#review36596 --- src/org/waveprotocol/wave/model/conversation/TitleHelper.java