Vicente, You should be marked as an admin now.
Ali On 13 March 2014 23:25, Vicente J. Ruiz Jurado <v...@ourproject.org> wrote: > > >> On March 9, 2014, 8:34 p.m., Ali Lown wrote: >> > LGTM. >> > Can I request that you document this new mode in >> > https://cwiki.apache.org/confluence/display/WAVE/Client+Development+Setup >> > once you commit this patch? > > Off course (Can you grant me permissions?). > > Commited: 3682cf9146cfc975eeabc77757aeccde5389edcb > > > - Vicente J. > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18941/#review36611 > ----------------------------------------------------------- > > > On March 8, 2014, 12:42 p.m., Vicente J. Ruiz Jurado wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/18941/ >> ----------------------------------------------------------- >> >> (Updated March 8, 2014, 12:42 p.m.) >> >> >> Review request for wave, Ali Lown, Pablo Ojanguren, and Yuri Zelikov. >> >> >> Bugs: WAVE-384 >> https://issues.apache.org/jira/browse/WAVE-384 >> >> >> Repository: wave >> >> >> Description >> ------- >> >> This patch add the GWT superdev mode to 'waveharness' and 'editor' that now >> works again. A refactorization is needed because some new functionalities >> had broken these GWT dev tools (WAVE-384). >> >> Note: GWT superdev mode in the full client (ant superdev-gwt) does not work >> yet because we need to replace socketio-java GWT dependency with an >> alternative (like atmosphere) or patched it with >> >> https://github.com/vjrj/Socket.IO-Java/commit/f7010aee1f5cc5adea0aab3f27e48c37d1b10b5e >> I think is more interesting the first option and seems that pablojan is >> working on it, because socketio-java update to jetty 9 websocket (#WAVE-405) >> version is not well documented: >> https://github.com/jetty-project/jetty-documentation/issues/12 >> Anyway, when the replacement is ready, we can just uncomment the xsiframe >> linker in WebClientDev.gwt.xml and Editor.gwt.xml. >> >> >> Diffs >> ----- >> >> build.xml 0a1b23c >> src/org/waveprotocol/box/webclient/WebClientDev.gwt.xml da32dd7 >> src/org/waveprotocol/box/webclient/client/ClientEvents.java 8b8e411 >> src/org/waveprotocol/box/webclient/client/DebugMessagePanel.java def986e >> src/org/waveprotocol/box/webclient/client/HistoryChangeListener.java >> ddcdb5d >> src/org/waveprotocol/box/webclient/client/HistoryProvider.java f207b83 >> src/org/waveprotocol/box/webclient/client/RemoteWaveViewService.java >> 8d4ff15 >> src/org/waveprotocol/box/webclient/client/SavedStateIndicator.java 3ee5c74 >> src/org/waveprotocol/box/webclient/client/SimpleWaveStore.java 83484c4 >> src/org/waveprotocol/box/webclient/client/StagesProvider.java dfca652 >> src/org/waveprotocol/box/webclient/client/WaveWebSocketClient.java 3bb39a2 >> src/org/waveprotocol/box/webclient/client/WebClient.java d3e3b49 >> src/org/waveprotocol/box/webclient/client/WindowTitleHandler.java ff1654f >> src/org/waveprotocol/box/webclient/client/events/DebugMessageEvent.java >> 6245489 >> >> src/org/waveprotocol/box/webclient/client/events/DebugMessageEventHandler.java >> 57f4659 >> src/org/waveprotocol/box/webclient/client/events/Log.java af132fe >> src/org/waveprotocol/box/webclient/client/events/NetworkStatusEvent.java >> e495cc0 >> >> src/org/waveprotocol/box/webclient/client/events/NetworkStatusEventHandler.java >> 034d062 >> src/org/waveprotocol/box/webclient/client/events/WaveCreationEvent.java >> ec59ccc >> >> src/org/waveprotocol/box/webclient/client/events/WaveCreationEventHandler.java >> 3ddf1a0 >> src/org/waveprotocol/box/webclient/client/events/WaveOpenEvent.java b5dcd75 >> src/org/waveprotocol/box/webclient/client/events/WaveOpenEventHandler.java >> f440d29 >> src/org/waveprotocol/box/webclient/client/events/WaveSelectionEvent.java >> a86469d >> >> src/org/waveprotocol/box/webclient/client/events/WaveSelectionEventHandler.java >> a35242c >> src/org/waveprotocol/box/webclient/search/SimpleSearch.java c79af80 >> src/org/waveprotocol/box/webclient/search/WaveBasedDigest.java 8c04db8 >> src/org/waveprotocol/box/webclient/search/WaveContext.java c8deb2a >> src/org/waveprotocol/box/webclient/search/WaveStore.java 2290737 >> src/org/waveprotocol/wave/client/StageTwo.java 557e838 >> >> src/org/waveprotocol/wave/client/common/util/UserAgentStaticProperties.java >> 0bca984 >> >> src/org/waveprotocol/wave/client/doodad/attachment/AttachmentManagerProvider.java >> PRE-CREATION >> src/org/waveprotocol/wave/client/editor/Editor.gwt.xml 78f3c26 >> src/org/waveprotocol/wave/client/events/ClientEvents.java PRE-CREATION >> src/org/waveprotocol/wave/client/events/DebugMessageEvent.java PRE-CREATION >> src/org/waveprotocol/wave/client/events/DebugMessageEventHandler.java >> PRE-CREATION >> src/org/waveprotocol/wave/client/events/Log.java PRE-CREATION >> src/org/waveprotocol/wave/client/events/NetworkStatusEvent.java >> PRE-CREATION >> src/org/waveprotocol/wave/client/events/NetworkStatusEventHandler.java >> PRE-CREATION >> src/org/waveprotocol/wave/client/events/WaveCreationEvent.java PRE-CREATION >> src/org/waveprotocol/wave/client/events/WaveCreationEventHandler.java >> PRE-CREATION >> src/org/waveprotocol/wave/client/events/WaveOpenEvent.java PRE-CREATION >> src/org/waveprotocol/wave/client/events/WaveOpenEventHandler.java >> PRE-CREATION >> src/org/waveprotocol/wave/client/events/WaveSelectionEvent.java >> PRE-CREATION >> src/org/waveprotocol/wave/client/events/WaveSelectionEventHandler.java >> PRE-CREATION >> src/org/waveprotocol/wave/client/testing/UndercurrentHarness.gwt.xml >> e48fd59 >> src/org/waveprotocol/wave/client/testing/UndercurrentHarness.java 22f7df6 >> >> src/org/waveprotocol/wave/client/wavepanel/impl/edit/ParticipantController.java >> 21995a6 >> src/org/waveprotocol/wave/model/conversation/TitleHelper.java 9402d67 >> src/org/waveprotocol/wave/model/document/WaveContext.java PRE-CREATION >> >> Diff: https://reviews.apache.org/r/18941/diff/ >> >> >> Testing >> ------- >> >> Run: >> ant waveharness-superdev >> Add the bookmarks in: http://localhost:9876/ >> and play with >> http://localhost:9876/waveharness/UndercurrentHarness.html >> so some code changes (for instance in UndercurrentHarness.java), click in >> "Dev mode on" in the bookmarks and recompile the module. >> >> Same with: >> ant editor-superdev >> >> >> Thanks, >> >> Vicente J. Ruiz Jurado >> >> >
