> On Dec. 16, 2012, 9:27 p.m., Yuri Zelikov wrote:
> > LGTM
> > Committed as r1422694
Thanks for the patch!
Can you please close the review request?
- Yuri
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8254/#review14566
---
Ship it!
LGTM
Committed as r1422694
- Yuri Zelikov
On Nov. 29, 20
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8254/
---
(Updated Nov. 29, 2012, 6:49 p.m.)
Review request for wave.
Description
--
> On Nov. 29, 2012, 12:34 a.m., Angus Turner wrote:
> > No obvious errors to me, looks good.
>
> Andrew Kaplanov wrote:
> I think better to close test file within try/catch block in finally
> section.
Hi Andrew,
I defently agree in case of production code. In case of tests, we may say tha
> On Nov. 29, 2012, 12:34 a.m., Angus Turner wrote:
> > No obvious errors to me, looks good.
I think better to close test file within try/catch block in finally section.
- Andrew
---
This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8254/#review13834
---
No obvious errors to me, looks good.
- Angus Turner
On Nov. 28, 20
