> On Nov. 29, 2012, 12:34 a.m., Angus Turner wrote: > > No obvious errors to me, looks good. > > Andrew Kaplanov wrote: > I think better to close test file within try/catch block in finally > section.
Hi Andrew, I defently agree in case of production code. In case of tests, we may say that try/catch may be an extra defence logic. If they have any problems, they will fail and a developer will fix. Anyway, it is a good chance to test me how to add extra diffs to the review :-) I am happy to do it. - Nikolay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8254/#review13834 ----------------------------------------------------------- On Nov. 28, 2012, 9:08 p.m., Nikolay Volnov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8254/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2012, 9:08 p.m.) > > > Review request for wave. > > > Description > ------- > > Hi, > > I've started exporing a wave project recently and found that 3 tests in > AttachmentStoreTest failed when I try to run it localy (OS: window 7). It > could not delete a tempory directory in tearDown method > (AttachmentStoreTest:49). Some input streams weren't closed in tests and it > blocked deleting the folder. > > > Diffs > ----- > > test/org/waveprotocol/box/server/persistence/AttachmentStoreTestBase.java > b5aae36 > > Diff: https://reviews.apache.org/r/8254/diff/ > > > Testing > ------- > > run all tests, status: PASSED > > > Thanks, > > Nikolay Volnov > >
