Re: Review Request: Fix for copy-paste in FF15

2012-10-01 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7142/#review12060 --- Committed as r1392275. - Yuri Zelikov On Sept. 25, 2012, 10:55 a.m

Re: Review Request: Fix for copy-paste in FF15

2012-10-01 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7142/#review12059 --- Ship it! LGTM. Only one comment below. src/org/waveprotocol/wave/c

Re: Review Request: Fix for copy-paste in FF15

2012-09-29 Thread Vicente J. Ruiz Jurado
> On Sept. 21, 2012, 4:04 p.m., Yuri Zelikov wrote: > > Hi. For some reason I can't apply the patch. Can you please try to generate > > it again? ping... - Vicente J. --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: Fix for copy-paste in FF15

2012-09-25 Thread Vicente J. Ruiz Jurado
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7142/ --- (Updated Sept. 25, 2012, 10:55 a.m.) Review request for wave, Michael MacFadden,

Re: Review Request: Fix for copy-paste in FF15

2012-09-21 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7142/#review11778 --- Hi. For some reason I can't apply the patch. Can you please try to ge

Re: Review Request: Fix for copy-paste in FF15

2012-09-18 Thread Vicente J. Ruiz Jurado
> On Sept. 18, 2012, 9:05 a.m., Yuri Zelikov wrote: > > src/org/waveprotocol/wave/client/common/util/UserAgentRuntimeProperties.java, > > line 35 > > > > > > Why we need to use GWT.isClient() here? Because if not, wave

Re: Review Request: Fix for copy-paste in FF15

2012-09-18 Thread Vicente J. Ruiz Jurado
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7142/ --- (Updated Sept. 18, 2012, 9:41 a.m.) Review request for wave, Michael MacFadden,

Re: Review Request: Fix for copy-paste in FF15

2012-09-18 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7142/#review11654 --- Hi, thanks for fixing this. Just minor comments. src/org/waveprotoc

Re: Review Request: Fix for copy-paste in FF15

2012-09-17 Thread Vicente J. Ruiz Jurado
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7142/ --- (Updated Sept. 18, 2012, 3:21 a.m.) Review request for wave, Michael MacFadden,