> On Sept. 18, 2012, 9:05 a.m., Yuri Zelikov wrote: > > src/org/waveprotocol/wave/client/common/util/UserAgentRuntimeProperties.java, > > line 35 > > <https://reviews.apache.org/r/7142/diff/1/?file=156058#file156058line35> > > > > Why we need to use GWT.isClient() here?
Because if not, waveharness-hosted and editor-hosted get a empty version for the user agent and not the real user agent, so, we cannot test correctly. I think that the intention was to return a empty string only with GWT tests. - Vicente J. ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7142/#review11654 ----------------------------------------------------------- On Sept. 18, 2012, 9:41 a.m., Vicente J. Ruiz Jurado wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7142/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2012, 9:41 a.m.) > > > Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown. > > > Description > ------- > > This patch fix the copy/paste issue in new ff15. I didn't find the root of > the changes in new FF that make the code to fail, but the implementation for > webkit works for ff >= 15 also while the previous ff implementation works > for ff < 15. Probably we can find a better solution with the help of this > patch that "focus" in the problem. > > > This addresses bug WAVE-370. > https://issues.apache.org/jira/browse/WAVE-370 > > > Diffs > ----- > > src/org/waveprotocol/wave/client/clipboard/PasteBufferImpl.java 3da6bfb > src/org/waveprotocol/wave/client/clipboard/PasteBufferImplOldFirefox.java > 2b210bb > > src/org/waveprotocol/wave/client/clipboard/PasteBufferImplSafariAndNewFirefox.java > c04c49b > src/org/waveprotocol/wave/client/common/util/QuirksConstants.java 378e93d > > src/org/waveprotocol/wave/client/common/util/UserAgentRuntimeProperties.java > 6a22782 > > Diff: https://reviews.apache.org/r/7142/diff/ > > > Testing > ------- > > ant waveharness-hosted ; ant editor-hosted ; ant test-gwt (after the change > in UserAgentRuntimeProperties that allows to make paste tests in > waveharness-hostes and editor-hosted and with specific versions of FF, I did > the test-gwt goal without failures) > > > Thanks, > > Vicente J. Ruiz Jurado > >
