Re: Review Request: Add prosody config generator

2013-06-08 Thread David van Eyssen
Unsubscribe thanks On 6/8/13 10:29 AM, "Bruno Gonzalez (aka stenyak)" wrote: >I've just updated the wiki instructions according to the new commit: >https://cwiki.apache.org/confluence/display/WAVE/Prosody+Installation > > >On Sat, Jun 8, 2013 at 1:09 PM, Ali Lown wrote: > >>This is an autom

Re: Review Request: Add prosody config generator

2013-06-08 Thread Bruno Gonzalez (aka stenyak)
I've just updated the wiki instructions according to the new commit: https://cwiki.apache.org/confluence/display/WAVE/Prosody+Installation On Sat, Jun 8, 2013 at 1:09 PM, Ali Lown wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11669/ > > O

Re: Review Request: Add prosody config generator

2013-06-08 Thread Ali Lown
> On June 8, 2013, 9:37 a.m., Yuri Zelikov wrote: > > Ship It! committed. - Ali --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11669/#review21614

Re: Review Request: Add prosody config generator

2013-06-08 Thread Yuri Zelikov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11669/#review21614 --- Ship it! Ship It! - Yuri Zelikov On June 6, 2013, 10:46 a.m., Br

Re: Review Request: Add prosody config generator

2013-06-06 Thread Ali Lown
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11669/#review21536 --- Ship it! LGTM. - Ali Lown On June 6, 2013, 10:46 a.m., Bruno Gon

Re: Review Request: Add prosody config generator

2013-06-06 Thread Bruno Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11669/ --- (Updated June 6, 2013, 10:46 a.m.) Review request for wave. Changes ---

Re: Review Request: Add prosody config generator

2013-06-06 Thread Ali Lown
> On June 6, 2013, 9:58 a.m., Ali Lown wrote: > > Thanks for this. > > > > Can I request that we do include s2s_ports, and component_ports in the > > generated configuration set to their default values. > > This is to make it explicit the relation between this, the component port > > setting i

Re: Review Request: Add prosody config generator

2013-06-06 Thread Bruno Gonzalez
> On June 6, 2013, 9:58 a.m., Ali Lown wrote: > > Thanks for this. > > > > Can I request that we do include s2s_ports, and component_ports in the > > generated configuration set to their default values. > > This is to make it explicit the relation between this, the component port > > setting i

Re: Review Request: Add prosody config generator

2013-06-06 Thread Ali Lown
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11669/#review21512 --- Thanks for this. Can I request that we do include s2s_ports, and co