> On June 6, 2013, 9:58 a.m., Ali Lown wrote: > > Thanks for this. > > > > Can I request that we do include s2s_ports, and component_ports in the > > generated configuration set to their default values. > > This is to make it explicit the relation between this, the component port > > setting in server.federation.config, and the port given in the SRV record. > > (Which I think can seem confusing to new users) > > > > (I do wonder whether it is better to just include prosody in-the-box > > instead?)
You mean the ports mentioned in the wiki page, right? component_ports = { 5275 } s2s_ports = { 5269 } If we include those settings in the config file, we must make sure that advanced Prosody users are aware of it. It could be something as simple as warning the user with an <echo> directive that displays: "NOTE: if you intend to use Prosody for more than just WaveInABox, then you need to manually review and tweak the generated file to ensure there's no conflicts in the configuration. Thanks." Does that sound good? Any other suggestions to deal with it? - Bruno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11669/#review21512 ----------------------------------------------------------- On June 6, 2013, 9:50 a.m., Bruno Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11669/ > ----------------------------------------------------------- > > (Updated June 6, 2013, 9:50 a.m.) > > > Review request for wave. > > > Description > ------- > > Adds a new ant target, that generates most of the configuration necessary to > federate using a Prosody XMPP server. > > > Diffs > ----- > > prosody.cfg.lua.example PRE-CREATION > server-config.xml 51b29fd > > Diff: https://reviews.apache.org/r/11669/diff/ > > > Testing > ------- > > - Run: > $ ant -f server-config.xml server-federation-config prosody-config -D... > $ sudo cp example.com.cfg.lua /etc/prosody/conf.d/example.com.cfg.lua > - Follow the rest of steps mentioned in the wiki about federation (to be > updated once this commit gets through). > - Restart Prosody and WiaB servers. > - Check that WiaB can connect to XMPP server. > > > Thanks, > > Bruno Gonzalez > >