Re: License headers

Ben, If you find any with multiple headers in src/ then that would be an actual issue. The file you are looking at is in gen/ is an auto-generated file during compilation, and so is building itself from some correctly headered files. Ali On 1 Jan 2014 09:58, "Ben Hegarty" wrote: > Hi Guys, > I

License headers

Hi Guys, I was just wondering if anyone knows why some files seem to have over a dozen copies of the license information scattered through them? Is this correct. for an example have a look at /wave-protocol/gen/messages/org/waveprotocol/box/attachment/gson/AttachmentMetadataGsonImpl.java Regards

Re: Review Request: Added missing Apache license headers for the "new wave with participant" patch

v. 10, 2012, 3:02 p.m.) > > > Review request for wave. > > > Description > --- > > Added missing Apache license headers for the "new wave with participant" patch > https://reviews.apache.org/r/7353/ > > > Diffs > - > > > s

Review Request: Added missing Apache license headers for the "new wave with participant" patch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8007/ --- Review request for wave. Description --- Added missing Apache license

Re: Review Request: Adding final license headers

I can ask him sure. Thanks Angus Turner angusisf...@gmail.com On Tue, Sep 25, 2012 at 10:24 PM, Upayavira wrote: > Or we ask Dan Peterson whether either he can remove them, or Google can > give us permission to remove them ourselves. > > Could you do that Angus? > > Thx, > > Upayavira > > On Tu

Re: Review Request: Adding final license headers

Or we ask Dan Peterson whether either he can remove them, or Google can give us permission to remove them ourselves. Could you do that Angus? Thx, Upayavira On Tue, Sep 25, 2012, at 12:15 PM, Angus Turner wrote: > > > > On Sept. 21, 2012, 3:54 p.m., Yuri Zelikov wrote: > > > @Ali, is this pat

Re: Review Request: Adding final license headers

> On Sept. 21, 2012, 3:54 p.m., Yuri Zelikov wrote: > > @Ali, is this patch ready? If so, can you commit it? > > Ali Lown wrote: > As Angus says at the end: "Just waiting for someone to weigh in re: > Google Headers" > TLDR: Should we still be keeping the "(C) Google" headers when we ha

Re: Review Request: Adding final license headers

> On Sept. 21, 2012, 3:54 p.m., Yuri Zelikov wrote: > > @Ali, is this patch ready? If so, can you commit it? > > Ali Lown wrote: > As Angus says at the end: "Just waiting for someone to weigh in re: > Google Headers" > TLDR: Should we still be keeping the "(C) Google" headers when we ha

Re: Review Request: Adding final license headers

I've subbed to the list and i'm watching. I tried to reply this morning but it didn't like it, maybe my phone's email is unhappy. Thanks Angus Turner angusisf...@gmail.com On Tue, Sep 25, 2012 at 5:12 PM, Upayavira wrote: > Yes, I have. See http://s.apache.org/qx6 for the progress made. I've >

Re: Review Request: Adding final license headers

Yes, I have. See http://s.apache.org/qx6 for the progress made. I've found the docs you got in the foundation records (under CCLAs not under software grants) and we now know that they do function as a grant (think grant covers existing code and CCLA covers future activity of employed contributors).

Re: Review Request: Adding final license headers

So you've sent one to legal-discuss? (just confirming) On 25/09/2012, at 7:33 AM, Upayavira wrote: > Oops, just sent one there... :-) > > Let's see if we get something back. > > Upayavira > > On Mon, Sep 24, 2012, at 09:28 PM, Angus Turner wrote: >> Hey Guys, >> I've gotten the original doc

Re: Review Request: Adding final license headers

Oops, just sent one there... :-) Let's see if we get something back. Upayavira On Mon, Sep 24, 2012, at 09:28 PM, Angus Turner wrote: > Hey Guys, > I've gotten the original documents back from Dan, it seems to was just > the > standard CCLA. I plan to write an email to legal-discuss now to sort

Re: Review Request: Adding final license headers

Hey Guys, I've gotten the original documents back from Dan, it seems to was just the standard CCLA. I plan to write an email to legal-discuss now to sort this out. I've made progress on a number of other fronts with the 3rd party libraries so i'll write up a status email after this is sorted out. T

Re: Review Request: Adding final license headers

Yeah I can do that. I'm inclined to think that they can go, as elsewhere in the code base it's just 'Copyright 2011 Google'. It'd be great to get the original agreements between Google and Apache to see what the terms were, which would also help to answer the question. I'd prefer to find them befor

Re: Review Request: Adding final license headers

I'm inclined to agree, but it would be wise for someone to subscribe to legal-discuss@a.o and ask there. Angus, would you be willing to do that? The question really is whether we have the right to do that, and it depends upon the documentation that Google have provided - i.e. did they sign a softw

Re: Review Request: Adding final license headers

> On Sept. 21, 2012, 3:54 p.m., Yuri Zelikov wrote: > > @Ali, is this patch ready? If so, can you commit it? > > Ali Lown wrote: > As Angus says at the end: "Just waiting for someone to weigh in re: > Google Headers" > TLDR: Should we still be keeping the "(C) Google" headers when we ha

Re: Review Request: Adding final license headers

> On Sept. 21, 2012, 3:54 p.m., Yuri Zelikov wrote: > > @Ali, is this patch ready? If so, can you commit it? As Angus says at the end: "Just waiting for someone to weigh in re: Google Headers" TLDR: Should we still be keeping the "(C) Google" headers when we have the Apache headers as well?

Re: Review Request: Adding final license headers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7077/#review11776 --- @Ali, is this patch ready? If so, can you commit it? - Yuri Zelikov

Re: Review Request: Adding final license headers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7077/ --- (Updated Sept. 14, 2012, 9:45 p.m.) Review request for wave. Changes ---

Re: Review Request: Adding final license headers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7077/#review11560 --- Ship it! Thanks. There are still a few spaces left floating, but we

Re: Review Request: Adding final license headers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7077/ --- (Updated Sept. 14, 2012, 12:30 a.m.) Review request for wave. Changes ---

Re: Review Request: Adding final license headers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7077/ --- (Updated Sept. 14, 2012, midnight) Review request for wave. Changes --- C

Re: Review Request: Adding final license headers

> On Sept. 13, 2012, 9:14 p.m., Ali Lown wrote: > > /spec/waveid/Makefile, line 1 > > > > > > Is this still meant to be here when under the Apache license? > > > > We have a lot of files like this and I don't ful

Re: Review Request: Adding final license headers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7077/#review11500 --- Here are a few suggestions to tidy up this patch a bit but it seems t

Re: Review Request: Adding final license headers

) - Adding final license headers Description --- Patch ensuring all the code headers are right, as well as the license and notice files. Diffs - /COPYING 1384205 /DISCLAIMER PRE-CREATION /NOTICES PRE-CREATION /build-proto.properties.example 1384205