----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7077/#review11500 -----------------------------------------------------------
Here are a few suggestions to tidy up this patch a bit but it seems to pretty comprehensively cover applying the correct license. /COPYING <https://reviews.apache.org/r/7077/#comment24640> I feel like some capital letters/correct branding are wanted here: "The OAuth" "WebSocket" "Socket.IO" etc. /COPYING <https://reviews.apache.org/r/7077/#comment24641> Ditto ("XPP3") /make_cert.sh <https://reviews.apache.org/r/7077/#comment24639> Whilst here can you get rid of all these spaces? /proto_src/org/waveprotocol/box/profile/ProfilesProto.java <https://reviews.apache.org/r/7077/#comment24643> And here. /server.config.example <https://reviews.apache.org/r/7077/#comment24642> And a space here. /spec/waveid/Makefile <https://reviews.apache.org/r/7077/#comment24644> Is this still meant to be here when under the Apache license? We have a lot of files like this and I don't fully understand how having multiple licenses works with this. /spec/waveid/waveidspec.html <https://reviews.apache.org/r/7077/#comment24645> Spaces... /src/org/waveprotocol/wave/client/editor/harness/public/EditorTest.css <https://reviews.apache.org/r/7077/#comment24648> I don't think you need to have an extra blank line in here. (And the same comment for all the other CSS files as well) /src/org/waveprotocol/wave/client/editor/harness/public/EditorTest.html <https://reviews.apache.org/r/7077/#comment24647> Some spaces. /src/org/waveprotocol/wave/client/testing/public/UndercurrentHarness.html <https://reviews.apache.org/r/7077/#comment24652> spaces. /src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditToolbar.css <https://reviews.apache.org/r/7077/#comment24665> Can we decide on '/**' or '/*'? Frow what I can see, '/**' is used in the Java code and '/*' is used in the CSS. /src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/attachment/AttachmentPopupWidget.css <https://reviews.apache.org/r/7077/#comment24653> Can we remove this blank space whilst here please. /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/BlipLinkPopupWidget.css <https://reviews.apache.org/r/7077/#comment24664> Whilst here there is a space. /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/RootThread.css <https://reviews.apache.org/r/7077/#comment24666> And a space here to tidy up. /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/mock/blip.html <https://reviews.apache.org/r/7077/#comment24667> And some here. /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/mock/ie_inline_thread.html <https://reviews.apache.org/r/7077/#comment24668> And here. /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/mock/inline_thread.html <https://reviews.apache.org/r/7077/#comment24669> ditto. /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/mock/participation.html <https://reviews.apache.org/r/7077/#comment24670> ditto. /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/mock/tmp_inline_thread.html <https://reviews.apache.org/r/7077/#comment24671> ditto. /src/org/waveprotocol/wave/client/widget/popup/DesktopTitleBar.css <https://reviews.apache.org/r/7077/#comment24672> Removing the space here would be good too. /src/org/waveprotocol/wave/client/widget/progress/ProgressWidget.css <https://reviews.apache.org/r/7077/#comment24673> And here. /tools/eclipse.sh <https://reviews.apache.org/r/7077/#comment24674> Why do we now have 2 blank lines here? /whitepapers/Makefile <https://reviews.apache.org/r/7077/#comment24675> And removing the trailing space here would be nice. When you get through that lot, I will be happy to take another look at it... - Ali Lown On Sept. 13, 2012, 6:22 a.m., Angus Turner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7077/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2012, 6:22 a.m.) > > > Review request for wave. > > > Description > ------- > > Patch ensuring all the code headers are right, as well as the license and > notice files. > > > Diffs > ----- > > /COPYING 1384205 > /DISCLAIMER PRE-CREATION > /NOTICES PRE-CREATION > /build-proto.properties.example 1384205 > /build.properties 1384205 > /check-certificates.sh 1384205 > /make_cert.sh 1384205 > /platforms/ubuntu/daemon-script.sh 1384205 > /platforms/ubuntu/server-wrapper.sh 1384205 > /process-script-args.sh 1384205 > /proto_src/org/waveprotocol/box/common/comms/WaveClientRpc.java 1384205 > /proto_src/org/waveprotocol/box/profile/ProfilesProto.java 1384205 > /proto_src/org/waveprotocol/box/search/SearchProto.java 1384205 > > /proto_src/org/waveprotocol/box/server/persistence/protos/ProtoAccountStoreData.java > 1384205 > > /proto_src/org/waveprotocol/box/server/persistence/protos/ProtoDeltaStoreData.java > 1384205 > /proto_src/org/waveprotocol/box/server/rpc/Rpc.java 1384205 > /proto_src/org/waveprotocol/protobuf/Extensions.java 1384205 > /proto_src/org/waveprotocol/wave/concurrencycontrol/ClientServer.java > 1384205 > /proto_src/org/waveprotocol/wave/diff/Diff.java 1384205 > /proto_src/org/waveprotocol/wave/federation/FederationErrorProto.java > 1384205 > /proto_src/org/waveprotocol/wave/federation/Proto.java 1384205 > /run-export.sh 1384205 > /run-import.sh 1384205 > /run-server.sh 1384205 > /server.config.example 1384205 > /server.federation.config.example 1384205 > /spec/waveid/Makefile 1384205 > /spec/waveid/waveidspec.html 1384205 > /src/org/waveprotocol/box/server/frontend/WaveViewSubscription.java 1384205 > /src/org/waveprotocol/box/server/gxp/OAuthAuthorizeTokenPage.gxp 1384205 > /src/org/waveprotocol/box/server/gxp/RobotRegistrationPage.gxp 1384205 > /src/org/waveprotocol/box/server/gxp/RobotRegistrationSuccessPage.gxp > 1384205 > /src/org/waveprotocol/box/server/gxp/UserRegistrationPage.gxp 1384205 > /src/org/waveprotocol/box/webclient/widget/frame/FramedPanel.css 1384205 > /src/org/waveprotocol/box/webclient/widget/loading/Loading.css 1384205 > /src/org/waveprotocol/pst/templates/api/beans.st 1384205 > /src/org/waveprotocol/pst/templates/api/enum.st 1384205 > /src/org/waveprotocol/pst/templates/api/interface.st 1384205 > /src/org/waveprotocol/pst/templates/builder/beans.st 1384205 > /src/org/waveprotocol/pst/templates/builder/buildField.st 1384205 > /src/org/waveprotocol/pst/templates/builder/class.st 1384205 > /src/org/waveprotocol/pst/templates/builder/fieldDeclaration.st 1384205 > /src/org/waveprotocol/pst/templates/builder/importUtil.st 1384205 > /src/org/waveprotocol/pst/templates/builder/imports.st 1384205 > /src/org/waveprotocol/pst/templates/gson/class.st 1384205 > /src/org/waveprotocol/pst/templates/gson/clearField.st 1384205 > /src/org/waveprotocol/pst/templates/gson/fromGsonField.st 1384205 > /src/org/waveprotocol/pst/templates/gson/fromGsonFieldInner.st 1384205 > /src/org/waveprotocol/pst/templates/gson/importUtil.st 1384205 > /src/org/waveprotocol/pst/templates/gson/imports.st 1384205 > /src/org/waveprotocol/pst/templates/gson/toGsonField.st 1384205 > /src/org/waveprotocol/pst/templates/gson/toGsonFieldInner.st 1384205 > /src/org/waveprotocol/pst/templates/jso/beans.st 1384205 > /src/org/waveprotocol/pst/templates/jso/class.st 1384205 > /src/org/waveprotocol/pst/templates/jso/importUtil.st 1384205 > /src/org/waveprotocol/pst/templates/jso/imports.st 1384205 > /src/org/waveprotocol/pst/templates/pojo/addHashCode.st 1384205 > /src/org/waveprotocol/pst/templates/pojo/beans.st 1384205 > /src/org/waveprotocol/pst/templates/pojo/class.st 1384205 > /src/org/waveprotocol/pst/templates/pojo/clearField.st 1384205 > /src/org/waveprotocol/pst/templates/pojo/copyField.st 1384205 > /src/org/waveprotocol/pst/templates/pojo/fieldDeclaration.st 1384205 > /src/org/waveprotocol/pst/templates/pojo/importUtil.st 1384205 > /src/org/waveprotocol/pst/templates/pojo/imports.st 1384205 > /src/org/waveprotocol/pst/templates/pojo/returnFalseIfNotEqual.st 1384205 > /src/org/waveprotocol/pst/templates/proto/beans.st 1384205 > /src/org/waveprotocol/pst/templates/proto/class.st 1384205 > /src/org/waveprotocol/pst/templates/proto/copyField.st 1384205 > /src/org/waveprotocol/pst/templates/proto/enumHelpers.st 1384205 > /src/org/waveprotocol/pst/templates/proto/fromGsonField.st 1384205 > /src/org/waveprotocol/pst/templates/proto/importUtil.st 1384205 > /src/org/waveprotocol/pst/templates/proto/imports.st 1384205 > /src/org/waveprotocol/pst/templates/proto/messageHelpers.st 1384205 > /src/org/waveprotocol/pst/templates/proto/splitPoint.st 1384205 > /src/org/waveprotocol/pst/templates/proto/toGsonField.st 1384205 > /src/org/waveprotocol/pst/templates/util/addHashCode.st 1384205 > /src/org/waveprotocol/pst/templates/util/class.st 1384205 > /src/org/waveprotocol/pst/templates/util/imports.st 1384205 > /src/org/waveprotocol/pst/templates/util/returnFalseIfNotEqual.st 1384205 > /src/org/waveprotocol/wave/client/doodad/attachment/render/Thumbnail.css > 1384205 > > /src/org/waveprotocol/wave/client/doodad/experimental/htmltemplate/secureStyles.css > 1384205 > /src/org/waveprotocol/wave/client/doodad/form/button/Button.css 1384205 > /src/org/waveprotocol/wave/client/doodad/form/check/Label.css 1384205 > /src/org/waveprotocol/wave/client/doodad/form/input/Input.css 1384205 > /src/org/waveprotocol/wave/client/doodad/form/input/Password.css 1384205 > /src/org/waveprotocol/wave/client/doodad/selection/CaretMarker.css 1384205 > /src/org/waveprotocol/wave/client/editor/Editor.css 1384205 > /src/org/waveprotocol/wave/client/editor/harness/public/EditorTest.css > 1384205 > /src/org/waveprotocol/wave/client/editor/harness/public/EditorTest.html > 1384205 > /src/org/waveprotocol/wave/client/editor/impl/DiffManager.css 1384205 > /src/org/waveprotocol/wave/client/editor/sugg/Suggestion.css 1384205 > /src/org/waveprotocol/wave/client/gadget/renderer/Gadget.css 1384205 > /src/org/waveprotocol/wave/client/testing/public/UndercurrentHarness.html > 1384205 > /src/org/waveprotocol/wave/client/wavepanel/impl/edit/KeepFocusInView.java > 1384205 > /src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/EditToolbar.css > 1384205 > > /src/org/waveprotocol/wave/client/wavepanel/impl/toolbar/attachment/AttachmentPopupWidget.css > 1384205 > /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/Blip.css 1384205 > > /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/BlipLinkPopupWidget.css > 1384205 > /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/Collapsible.css > 1384205 > > /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/ContinuationIndicator.css > 1384205 > /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/Conversation.css > 1384205 > /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/FocusFrame.css > 1384205 > /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/FocusFrameIE.css > 1384205 > /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/Participants.css > 1384205 > /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/ReplyBox.css > 1384205 > /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/RootThread.css > 1384205 > /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/mock/blip.css > 1384205 > /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/mock/blip.html > 1384205 > /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/mock/focus.css > 1384205 > > /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/mock/ie_inline_thread.css > 1384205 > > /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/mock/ie_inline_thread.html > 1384205 > > /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/mock/inline_thread.css > 1384205 > > /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/mock/inline_thread.html > 1384205 > > /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/mock/participation.html > 1384205 > > /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/mock/tmp_inline_thread.css > 1384205 > > /src/org/waveprotocol/wave/client/wavepanel/view/dom/full/mock/tmp_inline_thread.html > 1384205 > /src/org/waveprotocol/wave/client/widget/button/icon/IconButtonTemplate.css > 1384205 > > /src/org/waveprotocol/wave/client/widget/button/icon/IconButtonTemplate1.css > 1384205 > /src/org/waveprotocol/wave/client/widget/button/text/TextButton.css 1384205 > /src/org/waveprotocol/wave/client/widget/menu/Menu.css 1384205 > /src/org/waveprotocol/wave/client/widget/popup/DesktopTitleBar.css 1384205 > /src/org/waveprotocol/wave/client/widget/popup/DesktopUniversalPopup.css > 1384205 > /src/org/waveprotocol/wave/client/widget/popup/MobileUniversalPopup.css > 1384205 > > /src/org/waveprotocol/wave/client/widget/popup/desktopchrome/DesktopPopupChrome.css > 1384205 > > /src/org/waveprotocol/wave/client/widget/popup/desktopchrome/DropdownPopupChrome.css > 1384205 > /src/org/waveprotocol/wave/client/widget/profile/ProfilePopupWidget.css > 1384205 > /src/org/waveprotocol/wave/client/widget/progress/ProgressWidget.css > 1384205 > /src/org/waveprotocol/wave/client/widget/toolbar/SubmenuToolbarWidget.css > 1384205 > /src/org/waveprotocol/wave/client/widget/toolbar/ToplevelToolbarWidget.css > 1384205 > /src/org/waveprotocol/wave/communication/proto/Int52.java 1384205 > /test/com/google/wave/api/AttachmentRobotTest.java 1384205 > /test/org/waveprotocol/box/common/ExceptionalIteratorTest.java 1384205 > /test/org/waveprotocol/box/server/robots/RobotsTestBase.java 1384205 > /test/org/waveprotocol/box/server/rpc/WebSocketChannelTest.java 1384205 > /test/org/waveprotocol/wave/client/doodad/link/LinkTest.java 1384205 > > /test/org/waveprotocol/wave/client/wavepanel/impl/diff/DiffControllerTest.java > 1384205 > /tools/eclipse.sh 1384205 > /war/static/auth.css 1384205 > /whitepapers/Makefile 1384205 > > Diff: https://reviews.apache.org/r/7077/diff/ > > > Testing > ------- > > n/a > > > Thanks, > > Angus Turner > >
