Re: Review Request: Fixed so that GadgetWidget properly use its saved height for faster wave loading

2013-03-07 Thread wavegrove
Hi, Before I originally submitted the patch I tested all the gadgets in the default gadget list and could not find any problems. It is unfortunate that there is still some gadgets with problems. I can try to find the reason and hopefully the solution for the issue. - rocklund 2013/3/4 Vicente J

Re: Review Request: Fix for "WAVE-354: SimpleSearch.DigestProxy should undate only the opened wave on changes"

2013-01-13 Thread wavegrove
> On Jan. 12, 2013, 8:25 p.m., Yuri Zelikov wrote: > > Committed as r1432503 Thanks Yuri! :) - rocklund --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7683/#review15297 -

Re: Review Request: Fix for "WAVE-354: SimpleSearch.DigestProxy should undate only the opened wave on changes"

2012-12-18 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7683/ --- (Updated Dec. 18, 2012, 6:24 p.m.) Review request for wave. Changes --- R

Re: Review Request: Fixed so that GadgetWidget properly use its saved height for faster wave loading

2012-12-01 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8008/#review13934 --- Thanks for the review and commit Ali and Yuri! :) - rocklund On No

Re: Review Request: Fix for WAVE-374 and "New wave" responsiveness

2012-11-24 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7753/#review13699 --- Any comments on this? Is this a feature we would like to have? - roc

Review Request: Fixed so that GadgetWidget properly use its saved height for faster wave loading

2012-11-10 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8008/ --- Review request for wave. Description --- GadgetWidget already have a saved

Review Request: Added missing Apache license headers for the "new wave with participant" patch

2012-11-10 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8007/ --- Review request for wave. Description --- Added missing Apache license heade

Re: Review Request: Implementing the feature "New wave with the participants of the current wave"

2012-11-03 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7353/ --- (Updated Nov. 3, 2012, 1:07 p.m.) Review request for wave. Changes --- Re

Re: Review Request: Fix for "WAVE-354: SimpleSearch.DigestProxy should undate only the opened wave on changes"

2012-11-03 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7683/ --- (Updated Nov. 3, 2012, 12:49 p.m.) Review request for wave. Changes --- T

Review Request: Fix for WAVE-374 and "New wave" responsiveness

2012-10-27 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7753/ --- Review request for wave. Description --- This patch depends on https://revi

Re: Review Request: Implementing the feature "New wave with the participants of the current wave"

2012-10-22 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7353/ --- (Updated Oct. 22, 2012, 8:41 p.m.) Review request for wave. Changes --- T

Re: Review Request: Fix for "WAVE-354: SimpleSearch.DigestProxy should undate only the opened wave on changes"

2012-10-21 Thread wavegrove
> On Oct. 21, 2012, 4:16 p.m., Yuri Zelikov wrote: > > Hi > > I think the original issue was fixed by > > https://github.com/apache/wave/commit/2fbdcb9200b972d87d3667211ed0ce5db3326f53 > > and by > > https://github.com/apache/wave/commit/f34e33031801a1f2de4715a670a9c8c515c867d0 > > Or are there

Review Request: Fix for "WAVE-354: SimpleSearch.DigestProxy should undate only the opened wave on changes"

2012-10-20 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7683/ --- Review request for wave. Description --- Fix for "SimpleSearch.DigestProxy

Re: Review Request: Implementing the feature "New wave with the participants of the current wave"

2012-10-19 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7353/ --- (Updated Oct. 19, 2012, 4:54 p.m.) Review request for wave. Changes --- T

Re: Review Request: Implementing the feature "New wave with the participants of the current wave"

2012-10-12 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7353/ --- (Updated Oct. 12, 2012, 11:07 a.m.) Review request for wave. Changes ---

Re: Review Request: Implementing the feature "New wave with the participants of the current wave"

2012-10-01 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7353/ --- (Updated Oct. 1, 2012, 10:21 p.m.) Review request for wave. Description --

Re: Review Request: Implementing the feature "New wave with the participants of the current wave"

2012-10-01 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7353/ --- (Updated Oct. 1, 2012, 10:20 p.m.) Review request for wave. Changes --- U

Re: Review Request: Implementing the feature "New wave with the participants of the current wave"

2012-09-30 Thread wavegrove
> On Sept. 30, 2012, 2:09 a.m., Angus Turner wrote: > > > > Angus Turner wrote: > sorry my bad, it said > 'some tests would be great if possible' > > rocklund wrote: > I'm not sure if it is possible to add any testing for this since it is > mostly UI-driven code. I couldn't find an

Re: Review Request: Implementing the feature "New wave with the participants of the current wave"

2012-09-30 Thread wavegrove
> On Sept. 30, 2012, 2:09 a.m., Angus Turner wrote: > > > > Angus Turner wrote: > sorry my bad, it said > 'some tests would be great if possible' I'm not sure if it is possible to add any testing for this since it is mostly UI-driven code. I couldn't find any tests on wave opening and

Review Request: Implementing the feature "New wave with the participants of the current wave"

2012-09-29 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7353/ --- Review request for wave. Description --- I've started to create the functio

Re: Review Request: Implement wave-319: Improve the "Add gadget" popup

2012-04-01 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3960/ --- (Updated 2012-04-01 17:49:43.404931) Review request for wave. Changes ---

Re: Review Request: Implement wave-319: Improve the "Add gadget" popup

2012-04-01 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3960/ --- (Updated 2012-04-01 16:43:42.518573) Review request for wave. Changes ---

Re: Review Request: Implement wave-319: Improve the "Add gadget" popup

2012-03-24 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3960/ --- (Updated 2012-03-24 13:30:50.312549) Review request for wave. Changes ---

Re: Review Request: Implement wave-319: Improve the "Add gadget" popup

2012-03-17 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3960/ --- (Updated 2012-03-17 20:25:34.239494) Review request for wave. Changes ---

Re: Review Request: Implement wave-319: Improve the "Add gadget" popup

2012-03-11 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3960/ --- (Updated 2012-03-11 17:31:31.929113) Review request for wave. Changes ---

Re: Review Request: Implement wave-319: Improve the "Add gadget" popup

2012-03-04 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3960/ --- (Updated 2012-03-04 22:32:02.228552) Review request for wave. Changes ---

Re: Review Request: Implement wave-319: Improve the "Add gadget" popup

2012-02-26 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3960/ --- (Updated 2012-02-26 17:54:26.007681) Review request for wave. Changes ---

Re: Review Request: Implement wave-319: Improve the "Add gadget" popup

2012-02-23 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3960/ --- (Updated 2012-02-23 23:30:04.244231) Review request for wave. Changes ---

Re: Review Request: Implement wave-317: Allow adding (copy/pasting) multiple participants into a wave

2012-02-23 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3882/ --- (Updated 2012-02-23 16:41:26.330316) Review request for wave. Changes ---

Review Request: Implement wave-319: Improve the "Add gadget" popup

2012-02-19 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3960/ --- Review request for wave. Summary --- * Added more gadgets to the gadget lis

Re: Review Request: Implement wave-317: Allow adding (copy/pasting) multiple participants into a wave

2012-02-18 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3882/ --- (Updated 2012-02-18 12:54:05.737137) Review request for wave. Changes ---

Re: Review Request: Implement wave-317: Allow adding (copy/pasting) multiple participants into a wave

2012-02-16 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3882/ --- (Updated 2012-02-16 19:19:37.700527) Review request for wave. Changes ---

Re: Review Request: Implement wave-317: Allow adding (copy/pasting) multiple participants into a wave

2012-02-15 Thread wavegrove
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3882/ --- (Updated 2012-02-15 22:54:41.751527) Review request for wave. Changes ---