Hi, Before I originally submitted the patch I tested all the gadgets in the default gadget list and could not find any problems. It is unfortunate that there is still some gadgets with problems. I can try to find the reason and hopefully the solution for the issue.
- rocklund 2013/3/4 Vicente J. Ruiz Jurado <v...@ourproject.org> > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8008/ > > On March 4th, 2013, 11:22 a.m., *Yuri Zelikov* wrote: > > Umm, I think it would be better to try and fix the issues with gadgets that > don't work properly. Can you tell me what are the names of gadgets that don't > work? > > On March 4th, 2013, 1:17 p.m., *Vicente J. Ruiz Jurado* wrote: > > I don't know with gadgets use this feature without looking their code, but > for instance one of our gadgets > do:http://mass-mob.appspot.com/massmob/org.ourproject.massmob.client.MassmobGadget.gadget.xml > if you play with the disclosure panels and also opening/closing the wave, you > will see the gadget truncated in some point (some times even after adding the > gadget). But with this patch reverted you have the blip always with the > correct height. We were using this gadget for years without any problem. > > I don't remember now the name of other gadgets with the same problem. > > Ok, I've put the sample > ofhttps://developers.google.com/gadgets/docs/ui#Dyn_Height > here:http://homes.ourproject.org/~vjrj/otros/wave/gloce.xml > as you can see, you use the gadget, and if you reopen the gadget, you will > get a fixed height instead of a dynamic height. > > Sorry but I don't have more time to try to fix this. Because of that I was > suggesting to revert the patch. > > > - Vicente J. > > On November 10th, 2012, 4:50 p.m., rocklund wrote: > Review request for wave. > By rocklund. > > *Updated Nov. 10, 2012, 4:50 p.m.* > Description > > GadgetWidget already have a saved height property to be able to load its > correct height faster when a wave is loaded. This property was however not > properly used so gadget heights got changed several times during wave > loading, forcing the user to wait until all gadgets was loaded until he/she > could start to read the wave. > > This patch fixes so that gadgets load with their saved heights if they have > any. A new height is saved when the user perform an action on the gadget that > causes its height to be changed. This greatly improves the perceived load > time of waves with many gadgets. > > > Please review, thanks! > > Testing > > Tested on locally run server with most of the gadgets. Trying both the more > static gadgets and the gadgets that have more dynamic heights. > > Diffs > > - src/org/waveprotocol/wave/client/gadget/renderer/GadgetWidget.java > (f89abfd) > - src/org/waveprotocol/wave/client/gadget/renderer/GadgetWidgetUi.java > (50b205d) > > View Diff <https://reviews.apache.org/r/8008/diff/> >
