Re: Review Request 20610: Removing old dependency with socketio-java

2014-04-23 Thread Vicente J. Ruiz Jurado
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20610/ --- (Updated April 23, 2014, 4:21 p.m.) Review request for wave, Ali Lown, Pablo Oj

Re: Socket.IO script

2014-04-23 Thread Vicente J. Ruiz Jurado
El 04/23/14 10:08, Pablo Ojanguren escribió: > Hi, another alternative, > > As long as the problem comes from these third_party_dep's > > http://wave.alown.co.uk/third_party/socketio-core-0.1-SNAPSHOT.jar > http://wave.alown.co.uk/third_party/socketio-core-0.1-SNAPSHOT-sources.jar > http://wave.a

Review Request 20610: Removing old dependency with socketio-java

2014-04-23 Thread Vicente J. Ruiz Jurado
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20610/ --- Review request for wave, Ali Lown, Pablo Ojanguren, and Yuri Zelikov. Repositor

Re: Review Request 19355: Added Atmosphere framework as replacement of Socket.IO

2014-04-23 Thread Pablo Ojanguren
> On April 16, 2014, 6:59 a.m., Vicente J. Ruiz Jurado wrote: > > LGTM > > > > PS: Probably we have to use something like this in the future: > > http://www.eclipse.org/jetty/documentation/current/example-slf4j-multiple-loggers.html > > Ali Lown wrote: > @Vicente: Do you want to commit this

Re: Review Request 19355: Added Atmosphere framework as replacement of Socket.IO

2014-04-23 Thread Vicente J. Ruiz Jurado
> On April 16, 2014, 6:59 a.m., Vicente J. Ruiz Jurado wrote: > > LGTM > > > > PS: Probably we have to use something like this in the future: > > http://www.eclipse.org/jetty/documentation/current/example-slf4j-multiple-loggers.html > > Ali Lown wrote: > @Vicente: Do you want to commit this

Re: Review Request 17943: Inbox filter by date range

2014-04-23 Thread Vicente J. Ruiz Jurado
> On April 21, 2014, 10:40 a.m., Vicente J. Ruiz Jurado wrote: > > src/org/waveprotocol/box/webclient/search/SearchFilterDialogWidget.ui.xml, > > line 81 > > > > > > Is this checkbox really needed? Seems to me very str

Re: Socket.IO script

2014-04-23 Thread Pablo Ojanguren
Hi, another alternative, As long as the problem comes from these third_party_dep's http://wave.alown.co.uk/third_party/socketio-core-0.1-SNAPSHOT.jar http://wave.alown.co.uk/third_party/socketio-core-0.1-SNAPSHOT-sources.jar http://wave.alown.co.uk/third_party/socketio-jetty-0.1-SNAPSHOT.jar http