Re: Review Request 16322: full text search (with known issue of solr-bot output highlight)

2014-01-02 Thread Frank R.
> On Dec. 28, 2013, 3:01 a.m., Yuri Zelikov wrote: > > src/org/waveprotocol/box/server/waveserver/SolrSearchProviderImpl.java, > > line 285 > > > > > > Seems like the only modification is to skip results ordering - t

Re: P2P wave progress

2014-01-02 Thread Joseph Gentle
Yeah that was a longer email than I was expecting to write. Its fine - less bike shedding this way. The tech tree forks out here - there's (at least) 4 things to do next: - Get the net protocol working. Current version is local only. - I'd like to see it fast. Either rewrite the text-tp2 code to

Re: Delta store

2014-01-02 Thread Frank R.
I have one delta directory of 11MB at the moment, which consists of four files. One deltas file is 9.6MB. On Fri, Jan 3, 2014 at 12:45 AM, Ben Hegarty wrote: > Does anyone know if the deltas or index files are likely to ever hit 16MB, > as that is the maximum document size inside mongodb and if

Re: P2P wave progress

2014-01-02 Thread Thomas Wrobel
Thanks for tacking the time to explain that, that's really helpful to me. Sorry to have interrupted your original query. It does sound a distinct improvement and looks like you have put a lot of work into implementing it. Whats the next steps from here? ~~~ Thomas & Bertines online review show:

Re: P2P wave progress

2014-01-02 Thread Joseph Gentle
Peer-to-peer is a super overloaded term. It refers to somewhat symmetric peers communicating with each other directly instead of clients all talking to a central server. It gets overloaded to refer to anything that doesn't fit the classic client-server model. P2P systems usually have mechanisms fo

Re: Delta store

2014-01-02 Thread Ben Hegarty
Agreed, setting the WaveletDeltaRecord object as the top level document sounds sensible, I'll have a go at serializing it once I've built the rest of the model around it and created a workaround for the '.' issue that I'm seeing from attempting to save down the wave domain. I'll have to replace it

Re: Sometimes WIAB dosn't save

2014-01-02 Thread Vicente J. Ruiz Jurado
El 29/12/13 10:35, Raphael Bircher escribió: > Well, everytime switching libraries is also not a solution. Every > library has weeknesses. So, you solve maybe one problem and implement > two new. I prefer to solve the problem in our code if possible, or > upstream bugfixes to the libraries. (...) >

Re: Delta store

2014-01-02 Thread Pablo Ojanguren
The document size limit only matters in a document-per-wavelet data model approach. As long as updates (1) in existing documents are expensive operations in mongoDB a more granular approach would be suitable. I suggest a first simple data model with a document-per-delta approach, storing basicall

Re: Delta store

2014-01-02 Thread Ben Hegarty
Hey Yuri, I will do once I'm happy with the finished product, right now it's just a work in progress Regards Ben On Thursday, January 2, 2014, Yuri Z wrote: > Nice Ben. > Would you consider to create a code review with this patch on Review Board? > That will make it easier to review/comment on yo

Re: Delta store

2014-01-02 Thread Ben Hegarty
The question is more around how to go about modelling the data for mongodb, so that I don't hit any of Mongodb's limits. On Thursday, January 2, 2014, Ali Lown wrote: > I have seen the deltas files regularly hit >10MB. > The largest root conversation wavelet I have is 13300kB. (I think this > is

Re: Delta store

2014-01-02 Thread Yuri Z
Nice Ben. Would you consider to create a code review with this patch on Review Board? That will make it easier to review/comment on your patch. On Thu, Jan 2, 2014 at 7:07 PM, Pablo Ojanguren wrote: > Great! Ben, I am going to check out your patch and I will send you back > some feedback. By no

Re: Delta store

2014-01-02 Thread Pablo Ojanguren
Great! Ben, I am going to check out your patch and I will send you back some feedback. By now it's hard to know how much time the whole storage thing will take. And for sure I will need some help and knowledge from you. ;) 2014/1/2 Frank R. > This feature is on my wish list for Wave. It's a go

Re: Delta store

2014-01-02 Thread Ali Lown
I have seen the deltas files regularly hit >10MB. The largest root conversation wavelet I have is 13300kB. (I think this is only several hundred blips) My next question is why you are trying to store the serialized deltas for a whole wavelet in a single field in mongo? On 2 January 2014 16:45, Be

Re: Delta store

2014-01-02 Thread Ben Hegarty
Does anyone know if the deltas or index files are likely to ever hit 16MB, as that is the maximum document size inside mongodb and if we are then the persistence will need to be pushed into the mongodb GridFS? On Thu, Jan 2, 2014 at 9:58 AM, Frank R. wrote: > This feature is on my wish list for

Re: P2P wave progress

2014-01-02 Thread Thomas Wrobel
Excuse my ignorance in this, but can you briefly explain what "p2p" means in this context. I have only heard it used in the likes of torrent systems and such - the idea of a pure client system with no servers. Peers finding eachother with no server telling them who's where. A desktop wave applicat

Re: Delta store

2014-01-02 Thread Frank R.
This feature is on my wish list for Wave. It's a good news. Thank you~ On Thu, Jan 2, 2014 at 5:24 PM, Ben Hegarty wrote: > Hi Pablo, > Ironically I started work on this feature over the weekend as it is next on > my list of must haves for my own personal project which also uses MongoDB. > I've

Re: Delta store

2014-01-02 Thread Ben Hegarty
Hi Pablo, Ironically I started work on this feature over the weekend as it is next on my list of must haves for my own personal project which also uses MongoDB. I've had to upgrade the MongoDB driver and add in the morphia plugin for modelling the delta store which hopefully I'll be able to continu

Delta store

2014-01-02 Thread Pablo Ojanguren
Hi all, I am a developer working for an EU research project. There, we are going to use Wave (via Kune project) so we would like to help fixing bugs and improving the software along wiht the community. Currently I have some available time for this for the next 10 months. After check out the issue