> On Dec. 28, 2013, 3:01 a.m., Yuri Zelikov wrote: > > src/org/waveprotocol/box/server/waveserver/SolrSearchProviderImpl.java, > > line 285 > > <https://reviews.apache.org/r/16322/diff/10/?file=402364#file402364line285> > > > > Seems like the only modification is to skip results ordering - that > > will make the results returned by the search provider unstable. If you > > don't need ordering by queryParams, then it is still better to order by LMT > > and wave id which can be achived by passing Collections.emptySet() as the > > last argument to the original computeSearchResult() method. > > Frank R. wrote: > Ordering is taken care of by Solr - by relevance by default. See > > http://wiki.apache.org/solr/CommonQueryParameters#sort > > Currently, only the default ordering is implemented. > > Does it worth anything to pass in an empty set and invoke sortedCopy? > > Yuri Zelikov wrote: > Yeah, you are right. I had to make the method more modular, i.e. > extracting the sorting into a separate method that subclasses would be able > to ovveride: > > protected List<WaveViewData> sortResults(Map<TokenQueryType, > Set<String>> queryParams, > Map<WaveId, WaveViewData> results) { > return > QueryHelper.computeSorter(queryParams).sortedCopy(results.values()); > } > > and then calling it from computeSearchResult: > searchResultslist = > sortResults(queryParams, results) > .subList(startAt, endAt); > > Would you like me to make this change or would you prefer to make it by > yourself? >
It would best if you can do it. I'm sorry for the delay in response for the past holidays. I'd like to ask to postpone the review for some time so I can observe if the recent changes work well. - Frank ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16322/#review30918 ----------------------------------------------------------- On Dec. 23, 2013, 11:53 p.m., Frank R. wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16322/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2013, 11:53 p.m.) > > > Review request for wave, Ali Lown, Vicente J. Ruiz Jurado, and Yuri Zelikov. > > > Bugs: WAVE-311 > https://issues.apache.org/jira/browse/WAVE-311 > > > Repository: wave > > > Description > ------- > > For details (issues and commits): > https://github.com/renfeng/wave > > > Diffs > ----- > > run-export.sh d2cddb7 > run-import.sh 45fff8a > server.config.example 19ba8b2 > src/com/google/wave/api/Annotation.java b55f778 > src/org/waveprotocol/box/server/SearchModule.java 2de0ef9 > src/org/waveprotocol/box/server/ServerMain.java b50454d > src/org/waveprotocol/box/server/robots/agent/search/SolrRobot.java > PRE-CREATION > src/org/waveprotocol/box/server/robots/agent/welcome/WelcomeRobot.java > 2735940 > src/org/waveprotocol/box/server/waveserver/SimpleSearchProviderImpl.java > ee7093f > src/org/waveprotocol/box/server/waveserver/SolrSearchProviderImpl.java > PRE-CREATION > src/org/waveprotocol/box/server/waveserver/SolrWaveIndexerImpl.java > PRE-CREATION > src/org/waveprotocol/box/server/waveserver/WaveDigester.java b103bbb > > Diff: https://reviews.apache.org/r/16322/diff/ > > > Testing > ------- > > tests on search box > > * in:inbox > * (empty) for all, including waves shared in the domain > * with:@ > * (free texts) > > tests on solr-bot > > * single word > * phrase (quoted with double quotation marks) > * syntax applicable to search box > > > Thanks, > > Frank R. > >
