Re: Review Request: Adding final license headers

I can ask him sure. Thanks Angus Turner angusisf...@gmail.com On Tue, Sep 25, 2012 at 10:24 PM, Upayavira wrote: > Or we ask Dan Peterson whether either he can remove them, or Google can > give us permission to remove them ourselves. > > Could you do that Angus? > > Thx, > > Upayavira > > On Tu

Re: Review Request: Set some timeout to webclient search requests

> On Sept. 25, 2012, 11:12 a.m., Yuri Zelikov wrote: > > Ship It! Commited as r1389831. - Ali --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6885/#review11889 ---

Re: Review Request: Adding final license headers

Or we ask Dan Peterson whether either he can remove them, or Google can give us permission to remove them ourselves. Could you do that Angus? Thx, Upayavira On Tue, Sep 25, 2012, at 12:15 PM, Angus Turner wrote: > > > > On Sept. 21, 2012, 3:54 p.m., Yuri Zelikov wrote: > > > @Ali, is this pat

Re: Review Request: Make the 'presented' websocket address configurable

> On Sept. 24, 2012, 9:07 p.m., Yuri Zelikov wrote: > > Well, maybe it has something to do with waveinabox.net running on EC2... > > Anyway, the path LGTM. Commited as r1389830. - Ali --- This is an automatically generated e-mail. To re

Re: Review Request: Make the 'presented' websocket address configurable

> On Sept. 24, 2012, 8:38 p.m., Vicente J. Ruiz Jurado wrote: > > Great Ali, this was in my TODO list. Maybe I would use some different names > > instead of PRESENTED/PUBLIC (like FRONTEND/BACKEND or CLIENT/SERVER, etc) > > that seems confusing to me, but, besides that LGTM. I feel that 'clien

Re: Review Request: Adding final license headers

> On Sept. 21, 2012, 3:54 p.m., Yuri Zelikov wrote: > > @Ali, is this patch ready? If so, can you commit it? > > Ali Lown wrote: > As Angus says at the end: "Just waiting for someone to weigh in re: > Google Headers" > TLDR: Should we still be keeping the "(C) Google" headers when we ha

Review Request: Fix for deadlock in UserManager

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7253/ --- Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown. Descript

Re: Review Request: Adding final license headers

> On Sept. 21, 2012, 3:54 p.m., Yuri Zelikov wrote: > > @Ali, is this patch ready? If so, can you commit it? > > Ali Lown wrote: > As Angus says at the end: "Just waiting for someone to weigh in re: > Google Headers" > TLDR: Should we still be keeping the "(C) Google" headers when we ha

Re: Review Request: Set some timeout to webclient search requests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6885/#review11889 --- Ship it! Ship It! - Yuri Zelikov On Sept. 1, 2012, 3:33 p.m., Vic

Re: Review Request: Set some timeout to webclient search requests

> On Sept. 1, 2012, 8:11 p.m., Yuri Zelikov wrote: > > Can we maybe do this kind of logic on the server side? It seems like the > > responsibility of the server to buffer requests in case of latency. Then it > > will also work for other - API based clients like micro-box. > > Vicente J. Ruiz J

Re: Review Request: Set some timeout to webclient search requests

> On Sept. 1, 2012, 8:11 p.m., Yuri Zelikov wrote: > > Can we maybe do this kind of logic on the server side? It seems like the > > responsibility of the server to buffer requests in case of latency. Then it > > will also work for other - API based clients like micro-box. > > Vicente J. Ruiz J

Re: Review Request: Fix for copy-paste in FF15

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7142/ --- (Updated Sept. 25, 2012, 10:55 a.m.) Review request for wave, Michael MacFadden,

Re: Review Request: Fixes release-robot-client-api ant target

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7211/#review11886 --- Ship it! Ship It! - Vicente J. Ruiz Jurado On Sept. 21, 2012, 4:3

Re: Proxy issues

Comet isn't really an option. The socket.io code is still in the codebase, but if the browser is detected to have a websocket implementation they will be used instead. I was hoping to be able to remove the socket.io code soon since all major browsers now support websockets (ignoring IE<10). If y

Re: Proxy issues

Yep same as wave, firefox continually tries to authenticate and chrome just dies straight away, not that I know what it is but could we fall back to comet (because it seems to be ok) for situations like these? :( Bugger really wanted to be able to use wave, thanks again for all your help Ali, you'

Re: Proxy issues

So What happens in Firefox? Do you get asked to authenticate? On 25 Sep 2012 10:12, "Ben Hegarty" wrote: > 179664 > > On Tue, Sep 25, 2012 at 10:09 AM, Ali Lown wrote: > > > http://websocketstest.com >

Re: Proxy issues

What does http://websocketstest.com report? (Just link the report id) On 25 Sep 2012 10:07, "Ben Hegarty" wrote: > hmm I don't ever get an open connection in firefox, this doesn't seem to be > a problem other pages, i.e. gmail with GTalk works fine, facebook and all > the messaging there works fi

Re: Proxy issues

hmm I don't ever get an open connection in firefox, this doesn't seem to be a problem other pages, i.e. gmail with GTalk works fine, facebook and all the messaging there works fine too. The only time I've ever seen the authentication I got with wave is when I've had facebook open too long and I th

Re: Proxy issues

The firefox logs do show the attempts to authenticate (which is more than Chrome tries) at (say) #193,#194,#203,#204,#205,#213 which is a succesful login (I assume to open the connection for the page, since it is followed by #214 (TLSv1 Client Hello). The Websocket attempts (I think) look like #18

Re: Proxy issues

ok hopefuly this one is cleaner for firefox, though I have to add that firefox keeps asking for my credentials and no matter how many times I enter them it just keeps returning asking for them again... then after a while I just get a turbulence detected... https://docs.google.com/open?id=0B5FF_Ld8

Re: Proxy issues

In the chrome logs (original: #144, new: #344), in the firefox logs #274 show a 407 response to the attempt to CONNECT to wave.eezysys.co.uk:443. I would expect to possibly see a 407 once, at which stage the browser should then re-attempt the connection with the proxy credentials (as described her

Re: Proxy issues

Hey Ali, Was looking over the chrome capture and I'm not sure that the one below is very clean so I performed it again... https://docs.google.com/open?id=0B5FF_Ld8SzsNWG5rd0d0UnZVQU0 Regards hegsie On Tue, Sep 25, 2012 at 8:53 AM, Ben Hegarty wrote: > Hey Ali, > I've tested this again with fir

Re: Proxy issues

Hey Ali, I've tested this again with firefox to no avail... https://docs.google.com/open?id=0B5FF_Ld8SzsNaGFVV2NabEd0RFU and with chrome... https://docs.google.com/open?id=0B5FF_Ld8SzsNdmw5aThEZXF1U0k Regards hegsie On Mon, Sep 24, 2012 at 9:19 PM, Ben Hegarty wrote: > Ok, will do when I'm b

Re: Review Request: Adding final license headers

I've subbed to the list and i'm watching. I tried to reply this morning but it didn't like it, maybe my phone's email is unhappy. Thanks Angus Turner angusisf...@gmail.com On Tue, Sep 25, 2012 at 5:12 PM, Upayavira wrote: > Yes, I have. See http://s.apache.org/qx6 for the progress made. I've >

Re: Review Request: Adding final license headers

Yes, I have. See http://s.apache.org/qx6 for the progress made. I've found the docs you got in the foundation records (under CCLAs not under software grants) and we now know that they do function as a grant (think grant covers existing code and CCLA covers future activity of employed contributors).