----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7253/ -----------------------------------------------------------
Review request for wave, Michael MacFadden, Yuri Zelikov, and Ali Lown. Description ------- I think that the synchronized in UserManager.onUpdate can be the cause of the deadlock in WAVE-372. As matchSubscriptions is synchronized I think is not necessary at onUndate (in the same way onCommit is not synchronized). But anyway, comments, welcome. This addresses bug WAVE-372. https://issues.apache.org/jira/browse/WAVE-372 Diffs ----- src/org/waveprotocol/box/server/frontend/UserManager.java 35117f1 Diff: https://reviews.apache.org/r/7253/diff/ Testing ------- ./run-server.sh Thanks, Vicente J. Ruiz Jurado