[vpp-dev] Change how "unix exec" executes cli scripts

2022-05-08 Thread Damjan Marion via lists.fd.io
Guys, I just submitted following patch which fixes long standing issue in how cli scripts are executed. https://gerrit.fd.io/r/c/vpp/+/36101 Problem was that there was no way to execute CLIs which have optional arguments. I.e. “show version” and “show version verbose”. CLI parser was passing w

Re: [vpp-dev] Change how "unix exec" executes cli scripts

2022-05-08 Thread jiangxiaoming
Hi Damjan, With your patch, most of current clis have to be modified, it may be a large work. I think the suitable way is changing the meaning of VLIB_CLI_COMMAND function's second params from input to args. That's: /* CLI command callback function. */ typedef clib_error_t *( vlib_cli_command_fun

[vpp-dev] creating mpls tunnel with instance ID #mpls

2022-05-08 Thread Halit
Looks like this question has been asked before a few times and as far i see, answer was negative. I wonder if there is any change in plans. Is there any plan to create mpls tunnel with an ID like other tunnels/interfaces? - This would simplify certain automation. create ipip tunnel             

Re: [vpp-dev] creating mpls tunnel with instance ID #mpls

2022-05-08 Thread Pim van Pelt
Hoi, I don't know about the answer to MPLS, but did notice that GENEVE tunnels also cannot be explicitly created by id: create geneve tunnel create geneve tunnel local {remote |group } vni [encap-vrf-id ] [decap-next [l2|node ]] [l3-mode] [del] I agree that it (greatly) s

Re: [vpp-dev] creating mpls tunnel with instance ID #mpls

2022-05-08 Thread Neale Ranns
There’s no good reason MPLS tunnels don’t have that feature. We’d gladly accept the patch. /neale From: vpp-dev@lists.fd.io on behalf of Pim van Pelt via lists.fd.io Date: Monday, 9 May 2022 at 12:28 To: Halit Cc: vpp-dev@lists.fd.io Subject: Re: [vpp-dev] creating mpls tunnel with instan

[vpp-dev] crash at ethernet_input_inline_dmac_check nsh() with nsh pop action with encap-none #nsh

2022-05-08 Thread satyendra . mohapatra
Hi, I am observing a crash while trying to pop out NSH header with encap-none Client-1 <--- VPP_Switch <---(via VxLAN_gpe_tunnel)<--- (VPP as NSH Proxy)<---client-2 NSH Proxy sends packets with NSH header (SPI-185,SI-254) which VPP_Switch needs to decapsulate and sends to Client-1. During this

Re: [vpp-dev] Change how "unix exec" executes cli scripts

2022-05-08 Thread Andrew Yourtchenko
Damjan, I have left the comment on the change itself - in short, given its blast radius, it needs to wait at least until 22.06 RC1 is done. --a > On 8 May 2022, at 19:39, Damjan Marion via lists.fd.io > wrote: > > Guys, > > I just submitted following patch which fixes long standing issue i