Damjan, I have left the comment on the change itself - in short, given its blast radius, it needs to wait at least until 22.06 RC1 is done.
--a > On 8 May 2022, at 19:39, Damjan Marion via lists.fd.io > <dmarion=me....@lists.fd.io> wrote: > > Guys, > > I just submitted following patch which fixes long standing issue in how cli > scripts are executed. > > https://gerrit.fd.io/r/c/vpp/+/36101 > > Problem was that there was no way to execute CLIs which have optional > arguments. I.e. “show version” and “show version verbose”. > CLI parser was passing whole contents up to the EOF to each CLI handler, and > because he eats all whitespaces there was no way to know if current unformat > input points to the rest of the line or to the beginning of the new line. > > In this patch i changed that behaviour so CLI gets only one line of input. > > Also I changed unformat_input function so it recognises backslash before > newline as way to pass multiline data to cli handler. > > As a result, there is no need for calling unformat_line in each cli handler, > and still there is a way to specify multiline CLIs. > > i.e. > > show version \ > verbose > > or: > > packet-generator new { \ > name x \ > limit 5 \ > size 128-128 \ > interface local0 \ > node null-node \ > data { \ > incrementing 30 \ > } \ > } > > Hope nobody have issues with this change, but let me know if I’m wrong… > > — > Damjan > >
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#21388): https://lists.fd.io/g/vpp-dev/message/21388 Mute This Topic: https://lists.fd.io/mt/90974441/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
