Re: [vpp-dev] minor doc change

2020-11-28 Thread hemant via lists.fd.io
Paul, For all my work I use github. I used VPP github repo to make the doc change in a PR. See https://github.com/FDio/vpp/pull/32 If anyone can send me a link where bugs are filed against VPP gerrit repo, I can use the link to file issues. I haven’t used gerrit before but in futu

Re: [vpp-dev] minor doc change

2020-11-28 Thread Paul Vinciguerra
Hi Hermant, We don't see pull requests. Github is just a mirror of the gerrit repo. You can submit your change to the gerrit repo. See: [0] Bugs can be filed at [1] Paul [0] https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code#Pushing [1] https://jira.fd.io/pr

Re: [vpp-dev] minor doc change

2020-11-28 Thread hemant via lists.fd.io
Paul, Thanks for the links. I filed a new JIRA issue: https://jira.fd.io/browse/VPP-1951 I will look into gerrit repo to make the change. Hemant From: Paul Vinciguerra Sent: Saturday, November 28, 2020 1:19 PM To: hem...@mnkcg.com Cc: vpp-dev Subject: Re: [vpp-dev] minor doc ch

Re: [vpp-dev] Removing [backwards_compatible] from the .api

2020-11-28 Thread Paul Vinciguerra
Hi Ole. Comments inline. On Wed, Nov 25, 2020 at 4:46 PM wrote: > Hi Paul, > > > No. > > > > crc is actually a misnomer here. If you say crc, one assumes > binascii.crc32. That is not what crc is. What is exposed as .crc is > actually a custom function in vppapigen called foldup_blocks, whic