Paul,
Thanks for the links. I filed a new JIRA issue: https://jira.fd.io/browse/VPP-1951 I will look into gerrit repo to make the change. Hemant From: Paul Vinciguerra <pvi...@vinciconsulting.com> Sent: Saturday, November 28, 2020 1:19 PM To: hem...@mnkcg.com Cc: vpp-dev <vpp-dev@lists.fd.io> Subject: Re: [vpp-dev] minor doc change Hi Hermant, We don't see pull requests. Github is just a mirror of the gerrit repo. You can submit your change to the gerrit repo. See: [0] Bugs can be filed at [1] Paul [0] https://wiki.fd.io/view/VPP/Pulling,_Building,_Running,_Hacking_and_Pushing_VPP_Code#Pushing [1] https://jira.fd.io/projects/VPP/issues On Sat, Nov 28, 2020 at 12:58 PM <hem...@mnkcg.com <mailto:hem...@mnkcg.com> > wrote: Paul, For all my work I use github. I used VPP github repo to make the doc change in a PR. See https://github.com/FDio/vpp/pull/32 If anyone can send me a link where bugs are filed against VPP gerrit repo, I can use the link to file issues. I haven’t used gerrit before but in future I can try and use it. Thanks, Hemant From: Paul Vinciguerra <pvi...@vinciconsulting.com <mailto:pvi...@vinciconsulting.com> > Sent: Friday, November 27, 2020 10:47 PM To: hem...@mnkcg.com <mailto:hem...@mnkcg.com> Cc: vpp-dev <vpp-dev@lists.fd.io <mailto:vpp-dev@lists.fd.io> > Subject: Re: [vpp-dev] minor doc change Hi Hermant. The document is in the sources here: docs/gettingstarted/developers/infrastructure.md The best way to get the docs updated is to submit a change. Paul On Fri, Nov 27, 2020 at 8:37 PM hemant via lists.fd.io <http://lists.fd.io> <hemant=mnkcg....@lists.fd.io <mailto:mnkcg....@lists.fd.io> > wrote: At this link: https://my-vpp-docs.readthedocs.io/en/latest/gettingstarted/developers/infrastructure.html unformat_init_string() used two args but the latest VPP code uses three args. We should change the doc. Thanks, Hemant
smime.p7s
Description: S/MIME cryptographic signature
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#18187): https://lists.fd.io/g/vpp-dev/message/18187 Mute This Topic: https://lists.fd.io/mt/78559913/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-