Hi,
We have submitted a new review request for this issue (Change Id : 27729). We
have downgraded the API and declared it experimental. Kindly review the same.
Thanks and Regards,
Chinmaya Agarwal.
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#16
Chinmaya,
> To reiterate what we have understood, if we downgrade the api and declare it
> experimental (by setting "option version = 0.0.1"), we need not add "option
> status="in_progress" for the typedefs and messages we are modifying and we
> can simply use the original typedefs and message
Hi,
To reiterate what we have understood, if we downgrade the api and declare it
experimental (by setting "option version = 0.0.1"), we need not add "option
status="in_progress" for the typedefs and messages we are modifying and we can
simply use the original typedefs and messages and do the de
After we are done with changes 4, 5 and 6; we need to modify
> foreach_vpe_api_msg macro to register the appropriate handler functions.
>
> Is this what we are suppose to do or is there some other way to cater the new
> in-progress message?
>
>
> Thanks and Regards,
> Chinm
Chinmaya,
You have a couple of options.
You can downgrade the whole API and declare it experimental. That's done by
setting the semantic version to less than 1 in the .api file.
e.g. option version="0.0.1";
You can leave the API in production status, but mark those messages you believe
will cha
10:56 PM
To: Chinmaya Aggarwal
Cc: vpp-dev@lists.fd.io
Subject: Re: [vpp-dev] Fetching SR Policy data using VPP C API
CAUTION:This email originated from an external organization
Hi Chinmaya,
This fix causes an incompatible change to three messages because they are all
using the compound type
Hi Chinmaya,
This fix causes an incompatible change to three messages because they are all
using the compound type being modified... it *also* uncovered an at least a
year-long bug that would cause these changes slip under the radar - so thanks
for helping catch it ! :-)
You can rebase your pa
Fix for this issue submitted for gerrit review (Change Id : 27668 )
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#16813): https://lists.fd.io/g/vpp-dev/message/16813
Mute This Topic: https://lists.fd.io/mt/74894689/21656
Group Owner: vpp-dev+ow...@
Can anyone please suggest something for this?
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#16747): https://lists.fd.io/g/vpp-dev/message/16747
Mute This Topic: https://lists.fd.io/mt/74894689/21656
Group Owner: vpp-dev+ow...@lists.fd.io
Unsubscrib
