Hi Chinmaya, This fix causes an incompatible change to three messages because they are all using the compound type being modified... it *also* uncovered an at least a year-long bug that would cause these changes slip under the radar - so thanks for helping catch it ! :-)
You can rebase your patch for this change on top of any the versions in https://gerrit.fd.io/r/c/vpp/+/27677 and run “make checkstyle-api” to see what I am talking about.... I am working with Ole on how to address the issue, meantime if you can take a look at https://wiki.fd.io/view/VPP/ApiChangeProcess and consider which action is the most appropriate for this scenario. Thanks ! --a > On 25 Jun 2020, at 11:39, Chinmaya Aggarwal <chinmaya.agar...@hsc.com> wrote: > > Fix for this issue submitted for gerrit review (Change Id : 27668)
-=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#16819): https://lists.fd.io/g/vpp-dev/message/16819 Mute This Topic: https://lists.fd.io/mt/74894689/21656 Group Owner: vpp-dev+ow...@lists.fd.io Unsubscribe: https://lists.fd.io/g/vpp-dev/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
