Re: [vpp-dev] There is bug in patch

2022-09-28 Thread Guangming
s.fd.io > Cc: Zhang, Roy Fan ; Bronowski, PiotrX > ; Lijian Zhang ; > Honnappa Nagarahalli > Subject: Re: [vpp-dev] There is bug in patch > > Copying in Piotr, Fan and some other folks for awareness/any input. > > Best, > Zach > > On 28/09/2022 09:07, Zachary

Re: [vpp-dev] There is bug in patch

2022-09-28 Thread Benoit Ganne (bganne) via lists.fd.io
Zhang, Roy Fan ; Bronowski, PiotrX > ; Lijian Zhang ; > Honnappa Nagarahalli > Subject: Re: [vpp-dev] There is bug in patch > > Copying in Piotr, Fan and some other folks for awareness/any input. > > Best, > Zach > > On 28/09/2022 09:07, Zachary Leaf via lists.fd.io wr

Re: [vpp-dev] There is bug in patch

2022-09-28 Thread Zachary Leaf
Copying in Piotr, Fan and some other folks for awareness/any input. Best, Zach On 28/09/2022 09:07, Zachary Leaf via lists.fd.io wrote: > Hi Guangming, > > Thanks for the report. I think you may have uncovered some of the bugs > in the general inbound matching logic. > > I think there are 2 pro

Re: [vpp-dev] There is bug in patch

2022-09-28 Thread Zachary Leaf
Hi Guangming, Thanks for the report. I think you may have uncovered some of the bugs in the general inbound matching logic. I think there are 2 problems with the logic for the standard linear search (not flow cache, but impacts flow cache): 1. Only matches source/dest ip, and doesn't match source

[vpp-dev] There is bug in patch

2022-09-26 Thread Guangming
Hi, Zach I think there is a bug in patch : perf improvement of ipsec4_input_node using flow cache (https://gerrit.fd.io/r/c/vpp/+/32903). Based on current code , multiple spd rules were created that include some bypass or discard rule . When one ESP packet was received , we expect it mat