On 31/10/19 13:17, Paul Vinciguerra wrote:
Speaking for myself only, I would prefer that we didn't introduce per
platform changes. It would seem better to apply a single change that
makes it through the CI gates.
Are you OK with the way I implemented it [1]?
Is it time for a (non-voting) Ce
On 31/10/19 13:28, Renato Botelho do Couto wrote:
> On 31/10/19 13:17, Paul Vinciguerra wrote:
>> Speaking for myself only, I would prefer that we didn't introduce per
>> platform changes. It would seem better to apply a single change that
>> makes it through the CI gates.
>
> Right, I'll work on
On 31/10/19 13:39, Andrew 👽 Yourtchenko wrote:
> Renato,
>
> For my own curiosity sake - would you have a minute to try the following
> patch and instructions within it and tell the result ?
There is a list of good/bad shebangs used by brp-mangle-shebangs script.
This custom shebang line is not
Renato,
For my own curiosity sake - would you have a minute to try the following patch
and instructions within it and tell the result ?
https://gerrit.fd.io/r/#/c/vpp/+/23152/
--a
> On 31 Oct 2019, at 17:28, Renato Botelho do Couto via Lists.Fd.Io
> wrote:
>
> On 31/10/19 13:17, Paul Vinci
On 31/10/19 13:17, Paul Vinciguerra wrote:
> Speaking for myself only, I would prefer that we didn't introduce per
> platform changes. It would seem better to apply a single change that
> makes it through the CI gates.
Right, I'll work on a patch changing all shebang lines to python3 and
submit i
Speaking for myself only, I would prefer that we didn't introduce per
platform changes. It would seem better to apply a single change that makes
it through the CI gates.
Is it time for a (non-voting) Centos8 CI job?
On Thu, Oct 31, 2019 at 12:06 PM Renato Botelho do Couto
wrote:
> On 31/10/19
On 31/10/19 11:09, Paul Vinciguerra wrote:
> I am aware of the issue. I would suggest changing them all to python3.
> We can work through any issues that arise after the code passes the CI
> gates. Most of those shebangs are in place for developers using make
> test-shell, which could be evoking
Why not delete them altogether then?
--a
> On 31 Oct 2019, at 15:09, Paul Vinciguerra wrote:
>
>
> I am aware of the issue. I would suggest changing them all to python3. We
> can work through any issues that arise after the code passes the CI gates.
> Most of those shebangs are in place
I am aware of the issue. I would suggest changing them all to python3. We
can work through any issues that arise after the code passes the CI gates.
Most of those shebangs are in place for developers using make test-shell,
which could be evoking the script via 'python2 '
On Thu, Oct 31, 2019 at
I've been working to build VPP on CentOS 8 and rpmbuild is complaining
about using '#!/usr/bin/env python' or '#!/usr/bin/python' on scripts'
shebang line. It says it must to define explicitly if it's using
python2 or python3.
# git grep 'env python$' | wc -l
117
There are several scripts with t
10 matches
Mail list logo
