Re: [vpp-dev] 11th hour changes and code reviews

2020-05-04 Thread Christian Hopps
> On May 4, 2020, at 3:46 PM, Andrew Yourtchenko wrote: > More inline: >> On 4 May 2020, at 19:20, Paul Vinciguerra wrote: >> >> I agree that the change I submitted is a monster. Honestly, there are 2-5 >> git-friendly changes that could be refactored out of it. Its written and >> used by

Re: [vpp-dev] 11th hour changes and code reviews

2020-05-04 Thread Andrew Yourtchenko
Thanks for writing! Since i was the “-2“, first exec summary and then points inline: - CRC changing changes in 10 unrelated .api files at this point in time are borderline hostile activity to downstream users. Every CRC change means changes are required downstream. Sure it’s master but some fo

[vpp-dev] 11th hour changes and code reviews

2020-05-04 Thread Paul Vinciguerra
I was -2'd this morning for submitting a change with a "blast radius" this close to api freeze [0].  It was suggested that it should be discussed on the dev list and that multiple parties outside of vpp should have to +1 it.  I am glad to start the conversation. My change is dependent on anothe