"+", "_"))
716 print("#ifndef %s" % include_guard)
would you mind contributing a patch?
same change would be required in vapi_cpp_gen.py ...
Regards,
Klement
> On 27 Apr 2022, at 21:06, Renato Botelho do Couto via lists
(".", "_").replace("/", "_").replace("-",
> "_").replace(
> 715 "+", "_"))
> 716 print("#ifndef %s" % include_guard)
>
> would you mind contributing a patch?
>
> same chan
We use Jenkins to build VPP and after adding some matrix configuration
to one of our Jenkinsfiles I noticed VPP stop building.
When Jenkins builds the same project and use a second executor, it adds
'@2' to the end of ${WORKSPACE} directory name and I figured out this is
the cause of the break
On 31/10/19 13:17, Paul Vinciguerra wrote:
Speaking for myself only, I would prefer that we didn't introduce per
platform changes. It would seem better to apply a single change that
makes it through the CI gates.
Are you OK with the way I implemented it [1]?
Is it time for a (non-voting) Ce
On 31/10/19 13:28, Renato Botelho do Couto wrote:
> On 31/10/19 13:17, Paul Vinciguerra wrote:
>> Speaking for myself only, I would prefer that we didn't introduce per
>> platform changes. It would seem better to apply a single change that
>> makes it through the CI gates.
>
> Right, I'll work on
On 31/10/19 13:39, Andrew 👽 Yourtchenko wrote:
> Renato,
>
> For my own curiosity sake - would you have a minute to try the following
> patch and instructions within it and tell the result ?
There is a list of good/bad shebangs used by brp-mangle-shebangs script.
This custom shebang line is not
On 31/10/19 13:17, Paul Vinciguerra wrote:
> Speaking for myself only, I would prefer that we didn't introduce per
> platform changes. It would seem better to apply a single change that
> makes it through the CI gates.
Right, I'll work on a patch changing all shebang lines to python3 and
submit i
On 31/10/19 11:09, Paul Vinciguerra wrote:
> I am aware of the issue. I would suggest changing them all to python3.
> We can work through any issues that arise after the code passes the CI
> gates. Most of those shebangs are in place for developers using make
> test-shell, which could be evoking
I've been working to build VPP on CentOS 8 and rpmbuild is complaining
about using '#!/usr/bin/env python' or '#!/usr/bin/python' on scripts'
shebang line. It says it must to define explicitly if it's using
python2 or python3.
# git grep 'env python$' | wc -l
117
There are several scripts with t
